Lots of failures in the ChromeOS ozone asan/lsan config |
||||||||||||
Issue descriptionIn https://codereview.chromium.org/2949093004/ I switched the "Linux Chromium OS ASAN LSAN Tests" config from X11 to Ozone, and all sorts of tests exploded: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/22260 (see bug 740859 ). As a re-land attempt, I'm simply removing the test suites from that bot, but clearly we should make them work again. kylechar@, I'm gonna assign this to you if that's okay but I'm not sure who the right owner is.
,
Jul 14 2017
+erg, at least some of these failures are leaks related to image cursors:
#1 0x8d24ed in ui::X11CursorFactoryOzone::CreateImageCursor(SkBitmap const&, gfx::Point const&, float) ui/ozone/platform/x11/x11_cursor_factory_ozone.cc:55:28
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63e34448474381620aa6fce8c68b7f2c4ced7b75 commit 63e34448474381620aa6fce8c68b7f2c4ced7b75 Author: Dirk Pranke <dpranke@chromium.org> Date: Fri Jul 14 16:27:47 2017 Re-land "Remove all of the CrOS Ozone configs from MB". This change may affect the following builders: - chromium.chromiumos - Linux ChromiumOS Builder - Linux ChromiumOS Builder (dbg) - Linux ChromiumOS Full - chromium.fyi - Mojo ChromiumOS - chromium.gpu.fyi - Linux ChromiumOS Builder - Linux ChromiumOS Ozone Builder - chromium.memory - Linux Chromium OS ASan LSan Builder - Linux Chromium OS ASan LSan Tests (1) - Linux ChromiumOS MSan Builder - Linux ChromiumOS MSan Tests (1) - tryserver.chromium.linux - linux_chromium_chromeos_asan_rel_ng - linux_chromium_chromeos_compile_dbg_ng - linux_chromium_chromeos_compile_rel_ng - linux_chromium_chromeos_dbg_ng - linux_chromium_chromeos_msan_rel_ng - linux_chromium_chromeos_ozone_rel_ng - linux_chromium_chromeos_rel_ng The main difference from the last attempt is that this version removes ash_unittests, ash_content_unittests, browser_tests, interactive_ui_tests, and unit_tests from the ASan LSan Tests config, as they appear to be all kinds of busted. From the original CL (crrev.com/7385c63ec2): > Ozone is now on by default on all CrOS builds, and we don't > need to test the old x11 config any more. This CL flips > all of the CrOS builders to (implicitly) be building for Ozone, > so that we can then remove the explicit Ozone builders in a > follow-up CL. > > This builder also removes the > linux_chromium_chromeos_ozone_rel_ng builder from the CQ > since would otherwise be redundant with the > linux_chromium_chromeos_rel_ng builder. > > This CL also removes a couple of commented-out CQ entries for > builders that were removed as part of the work in bug 669297 > (linux_chromium_chromeos_compile_dbg_ng and linux_chromium_clobber_rel_ng); > at the time I had planned to re-add them once the capacity > issues were resolved, but at this point it's unclear how > important those configs are and we may want to use the > capacity for other things, and so these comments were misleading. BUG= 671355 , 742623 R=kylechar@chromium.org TBR=achuith@chromium.org, xdai@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_chromeos_asan_rel_ng,linux_chromium_chromeos_msan_rel_ng Change-Id: I27377846c8a7ad915b68ca99abb944de58631683 Reviewed-on: https://chromium-review.googlesource.com/571195 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486768} [modify] https://crrev.com/63e34448474381620aa6fce8c68b7f2c4ced7b75/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc [modify] https://crrev.com/63e34448474381620aa6fce8c68b7f2c4ced7b75/infra/config/cq.cfg [modify] https://crrev.com/63e34448474381620aa6fce8c68b7f2c4ced7b75/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/63e34448474381620aa6fce8c68b7f2c4ced7b75/testing/buildbot/chromium.memory.json [modify] https://crrev.com/63e34448474381620aa6fce8c68b7f2c4ced7b75/tools/mb/mb_config.pyl
,
Jul 14 2017
I'll take a look at the asan failures and add the tests back to the asan bot when I get that fixed. I wrote X11CursorFactoryOzone originally anyways. I'm not sure if it's an actual leak or if asan gets confused about the manual AddRef/RemoveRef on ref counted object.
,
Jul 26 2017
Linux Chromium OS ASan LSan Builder GN args: dcheck_always_on = true is_asan = true is_component_build = false is_debug = false is_lsan = true strip_absolute_paths_from_debug_symbols = true symbol_level = 1 target_os = "chromeos" use_goma = true
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4660042b48b211455a0ee3e5c0f9113a70d8a08 commit c4660042b48b211455a0ee3e5c0f9113a70d8a08 Author: kylechar <kylechar@chromium.org> Date: Thu Jul 27 16:00:32 2017 Fix CrOS Ozone tests for asan/lsan. When CrOS trybots were switched from X11 to Ozone a number of tests started failing on Linux Chromium OS ASan LSan Tests (1). This CL fixes a leak in OzoneCursorLoader and a use after free in SplitViewControllerTest. Enable ash_unittests and ash_content_unittests tests which pass again. Bug: 742623 Change-Id: I5d3e8d862598dd0ba2dc26c386ce550a90ded49b Reviewed-on: https://chromium-review.googlesource.com/587591 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#489948} [modify] https://crrev.com/c4660042b48b211455a0ee3e5c0f9113a70d8a08/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/c4660042b48b211455a0ee3e5c0f9113a70d8a08/testing/buildbot/chromium.memory.json [modify] https://crrev.com/c4660042b48b211455a0ee3e5c0f9113a70d8a08/ui/base/cursor/cursor_loader_ozone.cc
,
Jul 28 2017
unit_test failures: SafeBrowsingBlockingQuietPageTest.GiantWebView SafeBrowsingBlockingQuietPageTest.MalwarePage SafeBrowsingBlockingQuietPageTest.PhishingPage SafeBrowsingUIManagerTest.Whitelist SafeBrowsingUIManagerTest.WhitelistIgnoresPath SafeBrowsingUIManagerTest.WhitelistIgnoresSitesNotAdded SafeBrowsingUIManagerTest.WhitelistIgnoresThreatType SafeBrowsingUIManagerTest.WhitelistRemembersThreatType interactive_ui_tests pass, I'll add them back to the trybot now. browser_tests will hopefully finish running locally one day so I can see what fails.
,
Jul 28 2017
browser_test failures:
EncryptedMediaSupportedTypesExternalClearKeyNotEnabledTest.Basic (../../chrome/browser/media/encrypted_media_supported_types_browsertest.cc:657)
EncryptedMediaSupportedTypesExternalClearKeyTest.Audio_MP4 (../../chrome/browser/media/encrypted_media_supported_types_browsertest.cc:636)
EncryptedMediaSupportedTypesExternalClearKeyTest.Audio_WebM (../../chrome/browser/media/encrypted_media_supported_types_browsertest.cc:590)
EncryptedMediaSupportedTypesExternalClearKeyTest.Basic (../../chrome/browser/media/encrypted_media_supported_types_browsertest.cc:510)
EncryptedMediaSupportedTypesExternalClearKeyTest.InvalidKeySystems (../../chrome/browser/media/encrypted_media_supported_types_browsertest.cc:534)
EncryptedMediaSupportedTypesExternalClearKeyTest.NoCodecs (../../chrome/browser/media/encrypted_media_supported_types_browsertest.cc:522)
EncryptedMediaSupportedTypesExternalClearKeyTest.Video_MP4 (../../chrome/browser/media/encrypted_media_supported_types_browsertest.cc:609)
EncryptedMediaSupportedTypesExternalClearKeyTest.Video_WebM (../../chrome/browser/media/encrypted_media_supported_types_browsertest.cc:566)
MSE_ExternalClearKey/EncryptedMediaTest.ConfigChangeVideo_ClearToClear/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.ConfigChangeVideo_ClearToEncrypted/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.ConfigChangeVideo_EncryptedToClear/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.ConfigChangeVideo_EncryptedToEncrypted/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.EncryptedMediaDisabled/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.FrameSizeChangeVideo/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.InvalidResponseKeyError/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.Playback_AudioClearVideo_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.Playback_Multiple_VideoAudio_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.Playback_VP9Video_WebM_Fullsample/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.Playback_VP9Video_WebM_Subsample/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.Playback_VideoAudio_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.Playback_VideoAudio_WebM_Opus/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.Playback_VideoClearAudio_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.Playback_VideoClearAudio_WebM_Opus/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey/EncryptedMediaTest.PolicyCheck/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.ConfigChangeVideo_ClearToClear/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.ConfigChangeVideo_ClearToEncrypted/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.ConfigChangeVideo_EncryptedToClear/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.ConfigChangeVideo_EncryptedToEncrypted/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.EncryptedMediaDisabled/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.FrameSizeChangeVideo/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.InvalidResponseKeyError/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.Playback_AudioClearVideo_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.Playback_Multiple_VideoAudio_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.Playback_VP9Video_WebM_Fullsample/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.Playback_VP9Video_WebM_Subsample/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.Playback_VideoAudio_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.Playback_VideoAudio_WebM_Opus/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.Playback_VideoClearAudio_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.Playback_VideoClearAudio_WebM_Opus/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
MSE_ExternalClearKey_Mojo/EncryptedMediaTest.PolicyCheck/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
Mojo/ECKEncryptedMediaTest.CDMCrashDuringDecode/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Mojo/ECKEncryptedMediaTest.CDMExpectedCrash/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Mojo/ECKEncryptedMediaTest.DecryptOnly_VideoAudio_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Mojo/ECKEncryptedMediaTest.FileIOTest/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Mojo/ECKEncryptedMediaTest.InitializeCDMFail/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Mojo/ECKEncryptedMediaTest.LoadLoadableSession/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Mojo/ECKEncryptedMediaTest.LoadUnknownSession/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Mojo/ECKEncryptedMediaTest.OutputProtectionTest/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Mojo/ECKEncryptedMediaTest.PlatformVerificationTest/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Mojo/ECKEncryptedMediaTest.Renewal/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Mojo/ECKEncryptedMediaTest.StorageIdTest/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Pepper/ECKEncryptedMediaTest.CDMCrashDuringDecode/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Pepper/ECKEncryptedMediaTest.CDMExpectedCrash/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Pepper/ECKEncryptedMediaTest.DecryptOnly_VideoAudio_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Pepper/ECKEncryptedMediaTest.FileIOTest/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Pepper/ECKEncryptedMediaTest.InitializeCDMFail/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Pepper/ECKEncryptedMediaTest.LoadLoadableSession/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Pepper/ECKEncryptedMediaTest.LoadUnknownSession/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Pepper/ECKEncryptedMediaTest.OutputProtectionTest/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Pepper/ECKEncryptedMediaTest.PlatformVerificationTest/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Pepper/ECKEncryptedMediaTest.Renewal/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
Pepper/ECKEncryptedMediaTest.StorageIdTest/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:729)
SRC_ExternalClearKey/EncryptedMediaTest.ConfigChangeVideo_ClearToClear/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.ConfigChangeVideo_ClearToEncrypted/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.ConfigChangeVideo_EncryptedToClear/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.ConfigChangeVideo_EncryptedToEncrypted/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.EncryptedMediaDisabled/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.FrameSizeChangeVideo/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.InvalidResponseKeyError/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.Playback_AudioClearVideo_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.Playback_Multiple_VideoAudio_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.Playback_VP9Video_WebM_Fullsample/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.Playback_VP9Video_WebM_Subsample/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.Playback_VideoAudio_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.Playback_VideoAudio_WebM_Opus/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.Playback_VideoClearAudio_WebM/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.Playback_VideoClearAudio_WebM_Opus/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
SRC_ExternalClearKey/EncryptedMediaTest.PolicyCheck/0 (../../chrome/browser/media/encrypted_media_browsertest.cc:514)
,
Jul 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be261d6c0d4ec868c95007869751a3eec1f6ba10 commit be261d6c0d4ec868c95007869751a3eec1f6ba10 Author: kylechar <kylechar@chromium.org> Date: Sat Jul 29 01:36:55 2017 Enable interactive_ui_tests for CrOS asan/lsan. The test passes again after fixing a leak in CursorLoaderOzone. Add test back to Linux Chromium OS ASan LSan Tests (1). Bug: 742623 Change-Id: Ie8ef5bb4c335c48ebc793a9bf3597cfe16e6b584 Reviewed-on: https://chromium-review.googlesource.com/591616 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#490574} [modify] https://crrev.com/be261d6c0d4ec868c95007869751a3eec1f6ba10/testing/buildbot/chromium.memory.json
,
Aug 18 2017
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00a90b8647244d7d48dd1ac97e28c8869bb7041d commit 00a90b8647244d7d48dd1ac97e28c8869bb7041d Author: kylechar <kylechar@chromium.org> Date: Thu Aug 24 20:49:54 2017 Add browser_tests back to CrOS ASan trybot. Tests no longer fail when running locally, so it looks like original ODR violation was fixed. Bug: 742623 Change-Id: I46784bb866c2ec4e0d2092406020029d72a2ac75 Reviewed-on: https://chromium-review.googlesource.com/633136 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#497181} [modify] https://crrev.com/00a90b8647244d7d48dd1ac97e28c8869bb7041d/testing/buildbot/chromium.memory.json
,
Aug 25 2017
browser_tests has some flakey tests under ASan. SamlTest.ScrapedMultiple has failed in two runs. The failure isn't is some kind of crash but the stack trace isn't symbolized. TabRestoreTest.RestoreTabWithSpecialURL has failed once due to a leak. I might have to revert the browser_tests change for now.
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/265f1f0d7f9e58883aaa04a56938d3d46a9a1a71 commit 265f1f0d7f9e58883aaa04a56938d3d46a9a1a71 Author: kylechar <kylechar@chromium.org> Date: Sat Aug 26 00:31:03 2017 Revert "Add browser_tests back to CrOS ASan trybot." This reverts commit 00a90b8647244d7d48dd1ac97e28c8869bb7041d. Reason for revert: SamlTest.ScrapedMultiple test is flakey. Original change's description: > Add browser_tests back to CrOS ASan trybot. > > Tests no longer fail when running locally, so it looks like original ODR > violation was fixed. > > Bug: 742623 > Change-Id: I46784bb866c2ec4e0d2092406020029d72a2ac75 > Reviewed-on: https://chromium-review.googlesource.com/633136 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#497181} TBR=sky@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 742623 Change-Id: I21269c86a7b8ca6ba0fad82ca7000101b51481fe Reviewed-on: https://chromium-review.googlesource.com/635953 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#497610} [modify] https://crrev.com/265f1f0d7f9e58883aaa04a56938d3d46a9a1a71/testing/buildbot/chromium.memory.json
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1474c3ee4a892d535837c52d29dddfc75fe79f85 commit 1474c3ee4a892d535837c52d29dddfc75fe79f85 Author: kylechar <kylechar@chromium.org> Date: Mon Aug 28 19:54:12 2017 Enable tests on CrOS ASan trybot. Enable browser_tests and unit_tests on CrOS ASan trybot. Both tests have failing test cases, so add a filter file for both. Bug: 742623 , 756844 , 759291 Change-Id: Iffe10dba5d17f8539ebf57c18c0ef40e4e6221da Reviewed-on: https://chromium-review.googlesource.com/636397 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#497851} [modify] https://crrev.com/1474c3ee4a892d535837c52d29dddfc75fe79f85/testing/buildbot/chromium.memory.json [add] https://crrev.com/1474c3ee4a892d535837c52d29dddfc75fe79f85/testing/buildbot/filters/browser_tests_cros_asan.filter [add] https://crrev.com/1474c3ee4a892d535837c52d29dddfc75fe79f85/testing/buildbot/filters/unit_tests_cros_asan.filter
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/354d866de4a66eb05a285828d4931a83f34de7e2 commit 354d866de4a66eb05a285828d4931a83f34de7e2 Author: Henrik Andreasson <henrika@chromium.org> Date: Tue Aug 29 09:17:55 2017 Revert "Enable tests on CrOS ASan trybot." This reverts commit 1474c3ee4a892d535837c52d29dddfc75fe79f85. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=759944 Original change's description: > Enable tests on CrOS ASan trybot. > > Enable browser_tests and unit_tests on CrOS ASan trybot. Both tests have > failing test cases, so add a filter file for both. > > Bug: 742623 , 756844 , 759291 > Change-Id: Iffe10dba5d17f8539ebf57c18c0ef40e4e6221da > Reviewed-on: https://chromium-review.googlesource.com/636397 > Commit-Queue: kylechar <kylechar@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#497851} TBR=sky@chromium.org,kylechar@chromium.org Change-Id: I63f9a5a2baddf69b0d74d85edb51fb11cff35139 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 742623 , 756844 , 759291 Reviewed-on: https://chromium-review.googlesource.com/640710 Reviewed-by: Henrik Andreasson <henrika@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#498060} [modify] https://crrev.com/354d866de4a66eb05a285828d4931a83f34de7e2/testing/buildbot/chromium.memory.json [delete] https://crrev.com/d4287fc3f51190e6e8c698e36903b47c464596b1/testing/buildbot/filters/browser_tests_cros_asan.filter [delete] https://crrev.com/d4287fc3f51190e6e8c698e36903b47c464596b1/testing/buildbot/filters/unit_tests_cros_asan.filter
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4933d77d77e88629508587e5c36420d2e102c358 commit 4933d77d77e88629508587e5c36420d2e102c358 Author: kylechar <kylechar@chromium.org> Date: Tue Aug 29 17:32:36 2017 Enable tests on CrOS ASan trybot. Enable browser_tests and unit_tests on CrOS ASan trybot. Both tests have failing test cases, so add a filter file for both. Also add the filter files to data_deps in the appropriate test. The missing data_deps caused this CL to be reverted originally. Bug: 742623 , 756844 , 759291 Change-Id: If6f45f418d4afb7e17fd6c439aa90a9e4062cf08 Reviewed-on: https://chromium-review.googlesource.com/641210 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#498153} [modify] https://crrev.com/4933d77d77e88629508587e5c36420d2e102c358/chrome/test/BUILD.gn [modify] https://crrev.com/4933d77d77e88629508587e5c36420d2e102c358/testing/buildbot/chromium.memory.json [modify] https://crrev.com/4933d77d77e88629508587e5c36420d2e102c358/testing/buildbot/filters/BUILD.gn [add] https://crrev.com/4933d77d77e88629508587e5c36420d2e102c358/testing/buildbot/filters/browser_tests_cros_asan.filter [add] https://crrev.com/4933d77d77e88629508587e5c36420d2e102c358/testing/buildbot/filters/unit_tests_cros_asan.filter
,
Aug 29 2017
,
Aug 31 2017
,
Aug 31 2017
All the tests are back on the waterfall and there are no longer lots of failures thankfully. The bugs marked as blocking are for the couple of tests that were failing and are now filtered out on CrOS ASan.
,
Aug 31 2017
I wonder if ash_unittests--mash should run on that bot too.
,
Sep 8 2017
It looks like browser_tests MemoryTracingBrowserTest.TestBackgroundMemoryInfra and SiteDetailsBrowserTest.ManyIframes are flaky as well. I don't see any failures in them for the first few days, but both tests have failed a few times recently, so they could be new problems.
,
Oct 26 2017
MemoryTracingBrowserTest.TestBackgroundMemoryInfra is the only flaky test left it looks like. That is being investigated in crbug.com/778405 .
,
Nov 27 2017
TabRestoreTest.RestoreTabWithSpecialURL is still failing with leaks. Is there anything diagnosable there, or should the test be disabled?
,
Nov 27 2017
,
Mar 9 2018
Un-cc-ing me from all bugs on my final day.
,
Apr 13 2018
This bug was for tracking the original set of failures when switching over CrOS ASan trybot to Ozone instead of X11. All test suites were re-enabled and the configuration has been used for for ~8 months now. Anything that was flaky has been disabled with bugs filed against the test owners. I'm going to close this bug, please file a new bug if you find flakes on "Linux Chromium OS ASan LSan Tests (1)" |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by dpranke@chromium.org
, Jul 13 2017