Issue metadata
Sign in to add a comment
|
Caps Lock remapping setting not shown on Chromebooks with built-in Caps Lock keys |
||||||||||||||||||||||
Issue descriptionThere's a legacy_keyboard USE flag that we set for Chromeboxes, Chromebases, and Chromebooks with non-standard keyboards (parrot, stout, etc.). session_manager's chrome_setup.cc passes a --has-chromeos-keyboard flag to Chrome if legacy_keyboard is unset. chrome/browser/resources/options/chromeos/keyboard_overlay.html still has a reference to the flag; we used to show a Caps Lock remapping setting when the flag was missing. https://codereview.chromium.org/1269793005 removed Chrome's handling of the flag for issue 501121 , but I'm not sure of the reason why. https://crrev.com/1188693002 made Chrome only show the Caps Lock setting when an external keyboard is connected for issue 167237 (which was initially talking about Chromebooks with legacy keyboards, not external keyboards). Were Chromebooks with built-in Caps Lock keys overlooked when this change was made? I think we should show the Caps Lock remapping when an external keyboard is connected *or* when --has-chromeos-keyboard was not passed. Am I missing something?
,
Jul 13 2017
I'm going to make the change described above.
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dff8652057a92baab5770904c002840f7a6b00d commit 4dff8652057a92baab5770904c002840f7a6b00d Author: Daniel Erat <derat@chromium.org> Date: Tue Jul 18 00:06:17 2017 chromeos: Display Caps Lock setting for non-CrOS keyboards. Let the user remap the Caps Lock key when --has-chromeos-keyboard isn't provided (i.e. the internal keyboard has a Caps Lock key in place of Search). Formerly, the setting was only shown when an external keyboard was connected. Also add unit tests for KeyboardHandler and delete some unused variables. Unrelatedly, drop an accidentally-repeated call in PowerHandlerTest. BUG= 742613 Change-Id: I56d7ccb0bd5e054b9e815fb4d8d457c0729ada0c Reviewed-on: https://chromium-review.googlesource.com/572209 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#487298} [modify] https://crrev.com/4dff8652057a92baab5770904c002840f7a6b00d/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/4dff8652057a92baab5770904c002840f7a6b00d/chrome/browser/chromeos/login/chrome_restart_request.cc [modify] https://crrev.com/4dff8652057a92baab5770904c002840f7a6b00d/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc [modify] https://crrev.com/4dff8652057a92baab5770904c002840f7a6b00d/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.h [add] https://crrev.com/4dff8652057a92baab5770904c002840f7a6b00d/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler_unittest.cc [modify] https://crrev.com/4dff8652057a92baab5770904c002840f7a6b00d/chrome/browser/ui/webui/settings/chromeos/device_power_handler_unittest.cc [modify] https://crrev.com/4dff8652057a92baab5770904c002840f7a6b00d/chrome/browser/ui/webui/settings/md_settings_ui.cc [modify] https://crrev.com/4dff8652057a92baab5770904c002840f7a6b00d/chromeos/chromeos_switches.cc [modify] https://crrev.com/4dff8652057a92baab5770904c002840f7a6b00d/chromeos/chromeos_switches.h [modify] https://crrev.com/4dff8652057a92baab5770904c002840f7a6b00d/ui/events/test/device_data_manager_test_api.h [modify] https://crrev.com/4dff8652057a92baab5770904c002840f7a6b00d/ui/events/test/device_data_manager_test_api_impl.cc [modify] https://crrev.com/4dff8652057a92baab5770904c002840f7a6b00d/ui/events/test/device_data_manager_test_api_stub.cc
,
Jul 18 2017
Fix should go out in M61.
,
Jan 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by afakhry@chromium.org
, Jul 13 2017