Tablet mode may remember wrong orientation when the display is in rotation process |
||||||||
Issue descriptionNew rotation first makes copies of screen, and then rotate the display. If the device enters tablet mode, while the previous rotation request is still making copy, it may remember the wrong orientation.
,
Jul 14 2017
,
Jul 14 2017
This bug requires manual review: We are only 10 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 17 2017
,
Jul 18 2017
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e9ff0d0051f2a358d1f4f46b111fa101463bfcd commit 7e9ff0d0051f2a358d1f4f46b111fa101463bfcd Author: Mitsuru Oshima <oshima@chromium.org> Date: Tue Jul 18 21:23:16 2017 Remember the target rotation when entering the tablet mode New animation first makes copies of screen, and chagnes the rotation after these copies are made. If a device enters tablet mode while coyping it may remember the wrong rotation. BUG= 742605 TEST=covered by unit tests. Also tested manually: 1) Start portrait only ARC++ app 2) Try to close and open the lid multiple times (cherry picked from commit 397fe70fe94675f82c521d54374d79747465d2c7) Reviewed-on: https://chromium-review.googlesource.com/571258 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#486687} Change-Id: Ia4799c81b6bf206c9075977916fd087f55135479 Reviewed-on: https://chromium-review.googlesource.com/576469 Cr-Commit-Position: refs/branch-heads/3112@{#641} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/7e9ff0d0051f2a358d1f4f46b111fa101463bfcd/ash/display/display_configuration_controller.cc [modify] https://crrev.com/7e9ff0d0051f2a358d1f4f46b111fa101463bfcd/ash/display/display_configuration_controller.h [modify] https://crrev.com/7e9ff0d0051f2a358d1f4f46b111fa101463bfcd/ash/display/display_configuration_controller_unittest.cc [modify] https://crrev.com/7e9ff0d0051f2a358d1f4f46b111fa101463bfcd/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/7e9ff0d0051f2a358d1f4f46b111fa101463bfcd/ash/rotator/screen_rotation_animator.cc [modify] https://crrev.com/7e9ff0d0051f2a358d1f4f46b111fa101463bfcd/ash/rotator/screen_rotation_animator.h [modify] https://crrev.com/7e9ff0d0051f2a358d1f4f46b111fa101463bfcd/ash/rotator/screen_rotation_animator_unittest.cc
,
Jul 20 2017
,
Jul 31 2017
Verified on M60 build 9592.71.0 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 14 2017