New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742585 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Parser for Huddly firmware manifest file

Project Member Reported by porce@chromium.org, Jul 13 2017

Issue description

manifest class is to serve the parser class for manifest.json file which describes the meta data for the bundled firmware package, which in turn is used to determine the eligibility of firmware upgrade or downgrade.

huddly-manifest is a command line utility to perform this parsing for user/developer convenience, which can be used for future logging, testing, and development.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/huddly-updater/+/803cdc41fd1e7eff3902bb90005caad012fac817

commit 803cdc41fd1e7eff3902bb90005caad012fac817
Author: Jiwoong Lee <porce@google.com>
Date: Tue Jul 18 12:23:32 2017

Implement manifest class and command line utilty.

 - Parse JSON manifest file bundled with HuddlyGo camera firmware package.
 - Command line utility to be utilized in future logging and testing.
 - Manifest class will deprecate the use of manifest.txt, which is created
   in the build time.

BUG= chromium:742585 
TEST=Build guado package. Tested against R60 beta.

Change-Id: Id3efca632f17b5869ddc4dbfd10185a5e1e9a1c8
Reviewed-on: https://chromium-review.googlesource.com/570883
Commit-Ready: Jiwoong Lee <porce@chromium.org>
Tested-by: Jiwoong Lee <porce@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/803cdc41fd1e7eff3902bb90005caad012fac817/src/example/manifest.json
[add] https://crrev.com/803cdc41fd1e7eff3902bb90005caad012fac817/src/manifest_main.cc
[modify] https://crrev.com/803cdc41fd1e7eff3902bb90005caad012fac817/src/module.mk
[add] https://crrev.com/803cdc41fd1e7eff3902bb90005caad012fac817/src/manifest.cc
[add] https://crrev.com/803cdc41fd1e7eff3902bb90005caad012fac817/src/manifest.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3edb98fd8c7ecea5faf0d87f76afb29464425d10

commit 3edb98fd8c7ecea5faf0d87f76afb29464425d10
Author: Jiwoong Lee <porce@google.com>
Date: Thu Jul 27 22:44:03 2017

Add unit tests and command line utility for manifest class of huddly-updater

BUG= chromium:742585 
TEST=Build Guado package. Run cros_run_unit_tests.
CQ-DEPEND=CL:583578

Change-Id: Ide9c5bc7eedb000892954c820e1febd5d8fc3478
Reviewed-on: https://chromium-review.googlesource.com/583938
Commit-Ready: Jiwoong Lee <porce@chromium.org>
Tested-by: Jiwoong Lee <porce@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/3edb98fd8c7ecea5faf0d87f76afb29464425d10/sys-apps/huddly-updater/huddly-updater-9999.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/huddly-updater/+/efdca7fd8dfb370a3032d0de6f0a40ced0069356

commit efdca7fd8dfb370a3032d0de6f0a40ced0069356
Author: Jiwoong Lee <porce@google.com>
Date: Tue Aug 15 03:37:52 2017

Use JSON manifest instead of text one

Text manifest was an artifact created not to use JSON earlier.
Since JSON is the meta data directly provided from the vendor, and it is
more flexible to use, this CL deprecate the use of text version manifest,
and use JSON version directly.

BUG= chromium:742585 
TEST=Build Guado package. Run on the DUT.

Change-Id: I4258928c72745030ec5719ea25b054511d3ff616
Reviewed-on: https://chromium-review.googlesource.com/614054
Commit-Ready: Jiwoong Lee <porce@chromium.org>
Tested-by: Jiwoong Lee <porce@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/efdca7fd8dfb370a3032d0de6f0a40ced0069356/src/firmware.cc
[modify] https://crrev.com/efdca7fd8dfb370a3032d0de6f0a40ced0069356/src/firmware.h
[modify] https://crrev.com/efdca7fd8dfb370a3032d0de6f0a40ced0069356/src/module.mk
[modify] https://crrev.com/efdca7fd8dfb370a3032d0de6f0a40ced0069356/src/flasher.cc

Comment 5 by porce@chromium.org, Aug 21 2017

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment