enable AppsGridViewTest.MouseDragFlipPage for fullscreen app list |
|||||||
Issue descriptionMouse drag flip page can work properly for fullscreen app list, but I didn't figure out the unittest failure yet, open a bug for TODO.
,
Aug 18 2017
this is a test coverage change
,
Aug 19 2017
Approving merge to M61 Chrome OS.
,
Aug 22 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e916b86c6190b21b1577f398d34a57b9d32f244 commit 8e916b86c6190b21b1577f398d34a57b9d32f244 Author: Qiang Xu <warx@chromium.org> Date: Thu Aug 24 20:54:20 2017 m61 merge: app_list: enable AppsGridViewTest.MouseDragFlipPage for fullscreen launcher changes: (1) Make SimulateDrag always accept relative bounds, and convert it to bounds in root window, though they are the same for fullscreen launcher. (2) views::View::ConvertPointToWidget(apps_grid_view_, point) is missed in SimulateDrag as we have ConvertPointFromWidget in extracting drag point. (3) enable MouseDragFlipPage for fullscreen launcher. TBR: xiyuan@chromium.org (cherry picked from commit 50c03091987f4b6e663821a1c487485f9a1dd709) Bug: 742581 Test: covered by tests Change-Id: I49b85ea9154219ec222367507087efc4f63823f1 Reviewed-on: https://chromium-review.googlesource.com/620195 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#495733} Reviewed-on: https://chromium-review.googlesource.com/634222 Cr-Commit-Position: refs/branch-heads/3163@{#861} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/8e916b86c6190b21b1577f398d34a57b9d32f244/ui/app_list/views/apps_grid_view_unittest.cc
,
Aug 24 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Aug 18 2017