New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742581 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

enable AppsGridViewTest.MouseDragFlipPage for fullscreen app list

Project Member Reported by warx@chromium.org, Jul 13 2017

Issue description

Mouse drag flip page can work properly for fullscreen app list, but I didn't figure out the unittest failure yet, open a bug for TODO.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50c03091987f4b6e663821a1c487485f9a1dd709

commit 50c03091987f4b6e663821a1c487485f9a1dd709
Author: Qiang Xu <warx@chromium.org>
Date: Fri Aug 18 23:13:31 2017

app_list: enable AppsGridViewTest.MouseDragFlipPage for fullscreen launcher

changes:
(1) Make SimulateDrag always accept relative bounds, and convert it to
bounds in root window, though they are the same for fullscreen launcher.
(2) views::View::ConvertPointToWidget(apps_grid_view_, point) is missed
in SimulateDrag as we have ConvertPointFromWidget in extracting drag point.
(3) enable MouseDragFlipPage for fullscreen launcher.

Bug:  742581 
Test: covered by tests
Change-Id: I49b85ea9154219ec222367507087efc4f63823f1
Reviewed-on: https://chromium-review.googlesource.com/620195
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495733}
[modify] https://crrev.com/50c03091987f4b6e663821a1c487485f9a1dd709/ui/app_list/views/apps_grid_view_unittest.cc

Comment 2 by warx@chromium.org, Aug 18 2017

Labels: M-61 Merge-Request-61
this is a test coverage change

Comment 3 by ketakid@google.com, Aug 19 2017

Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 22 2017

Cc: ketakid@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e916b86c6190b21b1577f398d34a57b9d32f244

commit 8e916b86c6190b21b1577f398d34a57b9d32f244
Author: Qiang Xu <warx@chromium.org>
Date: Thu Aug 24 20:54:20 2017

m61 merge: app_list: enable AppsGridViewTest.MouseDragFlipPage for fullscreen launcher

changes:
(1) Make SimulateDrag always accept relative bounds, and convert it to
bounds in root window, though they are the same for fullscreen launcher.
(2) views::View::ConvertPointToWidget(apps_grid_view_, point) is missed
in SimulateDrag as we have ConvertPointFromWidget in extracting drag point.
(3) enable MouseDragFlipPage for fullscreen launcher.

TBR: xiyuan@chromium.org

(cherry picked from commit 50c03091987f4b6e663821a1c487485f9a1dd709)

Bug:  742581 
Test: covered by tests
Change-Id: I49b85ea9154219ec222367507087efc4f63823f1
Reviewed-on: https://chromium-review.googlesource.com/620195
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495733}
Reviewed-on: https://chromium-review.googlesource.com/634222
Cr-Commit-Position: refs/branch-heads/3163@{#861}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/8e916b86c6190b21b1577f398d34a57b9d32f244/ui/app_list/views/apps_grid_view_unittest.cc

Comment 6 by warx@chromium.org, Aug 24 2017

Status: Fixed (was: Assigned)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment