New issue
Advanced search Search tips

Issue 742569 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR



Sign in to add a comment

Add automated tests for app button exiting

Project Member Reported by bsheedy@chromium.org, Jul 13 2017

Issue description

 Issue 719997  and  Issue 715730  made the app button exit WebVR presentation/fullscreen mode, but we have yet to add any automated tests for this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/604301415a66f8cc62fda5bd67962179ffeefe75

commit 604301415a66f8cc62fda5bd67962179ffeefe75
Author: bsheedy <bsheedy@chromium.org>
Date: Mon Jul 17 17:21:17 2017

Add VR e2e tests for controller app button

Adds two VR instrumentation tests to check that pressing the Daydream
controller's "app" button causes the browser to exit WebVR presentation
and fullscreen.

Bug:  742569 ,  728779 
Change-Id: I11b92d876875e6224b30b0d5eab498786f698fbf
Reviewed-on: https://chromium-review.googlesource.com/571387
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487131}
[modify] https://crrev.com/604301415a66f8cc62fda5bd67962179ffeefe75/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java
[modify] https://crrev.com/604301415a66f8cc62fda5bd67962179ffeefe75/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellControllerInputTest.java
[modify] https://crrev.com/604301415a66f8cc62fda5bd67962179ffeefe75/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java

Status: Fixed (was: Started)
Components: Internals>XR

Sign in to add a comment