New issue
Advanced search Search tips

Issue 742564 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 742463
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 0
Type: Bug



Sign in to add a comment

Crash in SafeBrowsingResourceThrottle::MaybeCreate

Project Member Reported by shaktisahu@chromium.org, Jul 13 2017

Issue description

TOT is broken. Culprit CL:

https://chromium-review.googlesource.com/c/567394


Stack trace :

Stack frame #07 pc 00293001  /data/data/org.chromium.chrome/incremental-install-files/lib/libchrome.cr.so: Routine scoped_refptr<safe_browsing::SafeBrowsingDatabaseManager>::operator->() const at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../base/memory/ref_counted.h:523 (discriminator 4)
Stack frame #08 pc 002a1fcd  /data/data/org.chromium.chrome/incremental-install-files/lib/libchrome.cr.so: Routine SafeBrowsingResourceThrottle::MaybeCreate(net::URLRequest*, content::ResourceType, safe_browsing::SafeBrowsingService*) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../chrome/browser/loader/safe_browsing_resource_throttle.cc:50 (discriminator 2)
Stack frame #09 pc 002a1e83  /data/data/org.chromium.chrome/incremental-install-files/lib/libchrome.cr.so: Routine ChromeResourceDispatcherHostDelegate::AppendStandardResourceThrottles(net::URLRequest*, content::ResourceContext*, content::ResourceType, std::__ndk1::vector<std::__ndk1::unique_ptr<content::ResourceThrottle, std::__ndk1::default_delete<content::ResourceThrottle> >, std::__ndk1::allocator<std::__ndk1::unique_ptr<content::ResourceThrottle, std::__ndk1::default_delete<content::ResourceThrottle> > > >*) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc:707
Stack frame #10 pc 002a131f  /data/data/org.chromium.chrome/incremental-install-files/lib/libchrome.cr.so: Routine ChromeResourceDispatcherHostDelegate::RequestBeginning(net::URLRequest*, content::ResourceContext*, content::AppCacheService*, content::ResourceType, std::__ndk1::vector<std::__ndk1::unique_ptr<content::ResourceThrottle, std::__ndk1::default_delete<content::ResourceThrottle> >, std::__ndk1::allocator<std::__ndk1::unique_ptr<content::ResourceThrottle, std::__ndk1::default_delete<content::ResourceThrottle> > > >*) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc:575
Stack frame #11 pc 008f092b  /data/data/org.chromium.chrome/incremental-install-files/lib/libcontent.cr.so: Routine content::ResourceDispatcherHostImpl::AddStandardHandlers(net::URLRequest*, content::ResourceType, content::ResourceContext*, content::RequestContextType, blink::WebMixedContentContextType, content::AppCacheService*, int, int, std::__ndk1::unique_ptr<content::ResourceHandler, std::__ndk1::default_delete<content::ResourceHandler> >, content::NavigationURLLoaderImplCore*, std::__ndk1::unique_ptr<content::StreamHandle, std::__ndk1::default_delete<content::StreamHandle> >) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../content/browser/loader/resource_dispatcher_host_impl.cc:1618
Stack frame #12 pc 008f04eb  /data/data/org.chromium.chrome/incremental-install-files/lib/libcontent.cr.so: Routine content::ResourceDispatcherHostImpl::CreateResourceHandler(content::ResourceRequesterInfo*, net::URLRequest*, content::ResourceRequest const&, base::Callback<void (content::SyncLoadResult const*), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, content::ResourceContext*, mojo::AssociatedInterfaceRequest<content::mojom::URLLoader>, mojo::InterfacePtr<content::mojom::URLLoaderClient>) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../content/browser/loader/resource_dispatcher_host_impl.cc:1561
Stack frame #13 pc 008f0031  /data/data/org.chromium.chrome/incremental-install-files/lib/libcontent.cr.so: Routine content::ResourceDispatcherHostImpl::ContinuePendingBeginRequest(scoped_refptr<content::ResourceRequesterInfo>, int, content::ResourceRequest const&, base::Callback<void (content::SyncLoadResult const*), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, net::HttpRequestHeaders const&, mojo::AssociatedInterfaceRequest<content::mojom::URLLoader>, mojo::InterfacePtr<content::mojom::URLLoaderClient>, std::__ndk1::vector<std::__ndk1::unique_ptr<storage::BlobDataHandle, std::__ndk1::default_delete<storage::BlobDataHandle> >, std::__ndk1::allocator<std::__ndk1::unique_ptr<storage::BlobDataHandle, std::__ndk1::default_delete<storage::BlobDataHandle> > > >, net::NetworkTrafficAnnotationTag const&, content::HeaderInterceptorResult) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../content/browser/loader/resource_dispatcher_host_impl.cc:1486
Stack frame #14 pc 008eef65  /data/data/org.chromium.chrome/incremental-install-files/lib/libcontent.cr.so: Routine content::ResourceDispatcherHostImpl::BeginRequest(content::ResourceRequesterInfo*, int, content::ResourceRequest const&, base::Callback<void (content::SyncLoadResult const*), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, mojo::AssociatedInterfaceRequest<content::mojom::URLLoader>, mojo::InterfacePtr<content::mojom::URLLoaderClient>, net::NetworkTrafficAnnotationTag const&) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../content/browser/loader/resource_dispatcher_host_impl.cc:1230
Stack frame #15 pc 008eeaf9  /data/data/org.chromium.chrome/incremental-install-files/lib/libcontent.cr.so: Routine content::ResourceDispatcherHostImpl::OnRequestResourceInternal(content::ResourceRequesterInfo*, int, int, content::ResourceRequest const&, mojo::AssociatedInterfaceRequest<content::mojom::URLLoader>, mojo::InterfacePtr<content::mojom::URLLoaderClient>, net::NetworkTrafficAnnotationTag const&) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../content/browser/loader/resource_dispatcher_host_impl.cc:920
Stack frame #16 pc 008f19ab  /data/data/org.chromium.chrome/incremental-install-files/lib/libcontent.cr.so: Routine content::ResourceDispatcherHostImpl::OnRequestResourceWithMojo(content::ResourceRequesterInfo*, int, int, content::ResourceRequest const&, mojo::AssociatedInterfaceRequest<content::mojom::URLLoader>, mojo::InterfacePtr<content::mojom::URLLoaderClient>, net::NetworkTrafficAnnotationTag const&) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../content/browser/loader/resource_dispatcher_host_impl.cc:2272
Stack frame #17 pc 008fc7b5  /data/data/org.chromium.chrome/incremental-install-files/lib/libcontent.cr.so: Routine content::URLLoaderFactoryImpl::CreateLoaderAndStart(content::ResourceRequesterInfo*, mojo::AssociatedInterfaceRequest<content::mojom::URLLoader>, int, int, content::ResourceRequest const&, mojo::InterfacePtr<content::mojom::URLLoaderClient>, net::NetworkTrafficAnnotationTag const&) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../content/browser/loader/url_loader_factory_impl.cc:87
Stack frame #18 pc 008f6edf  /data/data/org.chromium.chrome/incremental-install-files/lib/libcontent.cr.so: Routine content::ResourceMessageFilter::CreateLoaderAndStart(mojo::AssociatedInterfaceRequest<content::mojom::URLLoader>, int, int, unsigned int, content::ResourceRequest const&, mojo::InterfacePtr<content::mojom::URLLoaderClient>, net::MutableNetworkTrafficAnnotationTag const&) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../content/browser/loader/resource_message_filter.cc:96
Stack frame #19 pc 0060b529  /data/data/org.chromium.chrome/incremental-install-files/lib/libcontent.cr.so: Routine content::mojom::URLLoaderFactoryStubDispatch::Accept(content::mojom::URLLoaderFactory*, mojo::Message*) at /usr/local/google/code/clankium/src/out-gn-android/Debug/gen/content/public/common/url_loader_factory.mojom.cc:395
Stack frame #20 pc 0001af9f  /data/data/org.chromium.chrome/incremental-install-files/lib/libbindings.cr.so: Routine mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:416
Stack frame #21 pc 0001abe1  /data/data/org.chromium.chrome/incremental-install-files/lib/libbindings.cr.so: Routine mojo::FilterChain::Accept(mojo::Message*) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../mojo/public/cpp/bindings/lib/filter_chain.cc:40
Stack frame #22 pc 0001ba5d  /data/data/org.chromium.chrome/incremental-install-files/lib/libbindings.cr.so: Routine mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:303
Stack frame #23 pc 0001e11b  /data/data/org.chromium.chrome/incremental-install-files/lib/libipc.cr.so: Routine IPC::(anonymous namespace)::ChannelAssociatedGroupController::Accept(mojo::Message*) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../ipc/ipc_mojo_bootstrap.cc:753
Stack frame #24 pc 0001abe1  /data/data/org.chromium.chrome/incremental-install-files/lib/libbindings.cr.so: Routine mojo::FilterChain::Accept(mojo::Message*) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../mojo/public/cpp/bindings/lib/filter_chain.cc:40
Stack frame #25 pc 00017fc7  /data/data/org.chromium.chrome/incremental-install-files/lib/libbindings.cr.so: Routine mojo::Connector::ReadSingleMessage(unsigned int*) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../mojo/public/cpp/bindings/lib/connector.cc:439 (discriminator 2)
Stack frame #26 pc 00018519  /data/data/org.chromium.chrome/incremental-install-files/lib/libbindings.cr.so: Routine mojo::Connector::ReadAllAvailableMessages() at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../mojo/public/cpp/bindings/lib/connector.cc:468
Stack frame #27 pc 00018445  /data/data/org.chromium.chrome/incremental-install-files/lib/libbindings.cr.so: Routine mojo::Connector::OnHandleReadyInternal(unsigned int) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../mojo/public/cpp/bindings/lib/connector.cc:373
Stack frame #28 pc 00018fdf  /data/data/org.chromium.chrome/incremental-install-files/lib/libbindings.cr.so: Routine void base::internal::Invoker<base::internal::BindState<void (mojo::Connector::*)(unsigned int), base::internal::UnretainedWrapper<mojo::Connector> >, void (unsigned int)>::RunImpl<void (mojo::Connector::* const&)(unsigned int), std::__ndk1::tuple<base::internal::UnretainedWrapper<mojo::Connector> > const&, 0u>(void (mojo::Connector::* const&)(unsigned int), std::__ndk1::tuple<base::internal::UnretainedWrapper<mojo::Connector> > const&, base::IndexSequence<0u>, unsigned int&&) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../base/bind_internal.h:351
Stack frame #29 pc 00016b9d  /data/data/org.chromium.chrome/incremental-install-files/lib/libbindings.cr.so: Routine base::Callback<void (unsigned int), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>::Run(unsigned int) const & at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../base/callback.h:80 (discriminator 4)
Stack frame #30 pc 000059d5  /data/data/org.chromium.chrome/incremental-install-files/lib/libmojo_public_system_cpp.cr.so: Routine base::Callback<void (unsigned int, mojo::HandleSignalsState const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>::Run(unsigned int, mojo::HandleSignalsState const&) const & at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../base/callback.h:80 (discriminator 6)
Stack frame #31 pc 0000590f  /data/data/org.chromium.chrome/incremental-install-files/lib/libmojo_public_system_cpp.cr.so: Routine mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../mojo/public/cpp/system/simple_watcher.cc:276
Stack frame #32 pc 00005cc7  /data/data/org.chromium.chrome/incremental-install-files/lib/libmojo_public_system_cpp.cr.so: Routine void base::internal::InvokeHelper<true, void>::MakeItSo<void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher> const&, int const&, unsigned int const&, mojo::HandleSignalsState const&>(void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher> const&, int const&, unsigned int const&, mojo::HandleSignalsState const&) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../base/bind_internal.h:295 (discriminator 2)
Stack frame #33 pc 00005c99  /data/data/org.chromium.chrome/incremental-install-files/lib/libmojo_public_system_cpp.cr.so: Routine void base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::RunImpl<void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__ndk1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, 0u, 1u, 2u, 3u>(void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__ndk1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, base::IndexSequence<0u, 1u, 2u, 3u>) at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../base/bind_internal.h:351
Stack frame #34 pc 0008ab8b  /data/data/org.chromium.chrome/incremental-install-files/lib/libbase.cr.so: Routine base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>::Run() && at /usr/local/google/code/clankium/src/out-gn-android/Debug/../../base/callback.h:91 (discriminator 2)

 

Comment 1 by vakh@chromium.org, Jul 13 2017

Status: Started (was: Assigned)

Comment 2 by vakh@chromium.org, Jul 13 2017

FWIW -- that CL did not touch chrome/browser/loader/safe_browsing_resource_throttle.cc

Comment 3 by vakh@chromium.org, Jul 13 2017

This could also be related to  bug 742463 .
There are actually two very similar crashes, in safe_browsing_resource_throttle.cc and chrome_subresource_filter_client.cc. I added some comments in the CL on what is failing.

Comment 5 by vakh@chromium.org, Jul 13 2017

Mergedinto: 742463
Status: Duplicate (was: Started)

Sign in to add a comment