New issue
Advanced search Search tips

Issue 742557 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

ReaderInitParams::ReaderFunctor can just be a function pointer instead of a base::Callback

Project Member Reported by juncai@chromium.org, Jul 13 2017

Issue description

From the discussion at:
https://chromium-review.googlesource.com/c/569058/2/services/device/generic_sensor/platform_sensor_reader_win.cc

By doing this, we don't need to use base::Bind() since it adds overhead.
 

Comment 1 by juncai@chromium.org, Jul 31 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e73eb5fb23e0e925cdc81922f8e6c15e3341a244

commit e73eb5fb23e0e925cdc81922f8e6c15e3341a244
Author: Jun Cai <juncai@chromium.org>
Date: Tue Aug 01 04:04:59 2017

Change device::ReaderInitParams::ReaderFunctor to be a function pointer

This CL changes device::ReaderInitParams::ReaderFunctor to be a function
pointer instead of a base::Callback. By doing this, we don't need to
use base::Bind() since it adds overhead.

Bug:  742557 
Change-Id: Ibfc05a481db36747ad3c74a7592d1862726b5520
Reviewed-on: https://chromium-review.googlesource.com/594888
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490845}
[modify] https://crrev.com/e73eb5fb23e0e925cdc81922f8e6c15e3341a244/services/device/generic_sensor/platform_sensor_reader_win.cc

Status: Fixed (was: Started)

Sign in to add a comment