Dragging from bezel does not always close the app list |
||||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? (1)Start a drag 1/10 from the bottom bezel (2)Drag to the bezel (3) What is the expected result? launcher closes What happens instead? launcher doesn't close. The launcher will close if the drag is started further up the screen. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Aug 23 2017
,
Aug 23 2017
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 23 2017
Approving merge to M61 Chrome OS.
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63b5efdda6e5c9b491880e15c79ca7157a7fbb21 commit 63b5efdda6e5c9b491880e15c79ca7157a7fbb21 Author: Alex Newcomer <newcomer@chromium.org> Date: Wed Aug 23 20:01:36 2017 cros: Drag to bezel should close. Two small fixes in this CL with accompanying tests. 1. Dragging the launcher to within the bezel margin should close the launcher. It was implemented incorrectly and is now working. verified with a new test! 2. New Ux Behavior: Flinging the launcher down from any state should close it. Verified with a new test! Bug: 742542 Change-Id: I244dbb841d030f8028431de9ef50b34cb4566d54 Reviewed-on: https://chromium-review.googlesource.com/629197 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#496776} [modify] https://crrev.com/63b5efdda6e5c9b491880e15c79ca7157a7fbb21/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/63b5efdda6e5c9b491880e15c79ca7157a7fbb21/ui/app_list/views/app_list_view.cc
,
Aug 24 2017
,
Aug 28 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35747ab75f6dac0eadc542afc5640cf95f69b12f commit 35747ab75f6dac0eadc542afc5640cf95f69b12f Author: Maajid <maajid@chromium.org> Date: Wed Aug 30 01:47:27 2017 cros: Drag to bezel should close. Two small fixes in this CL with accompanying tests. 1. Dragging the launcher to within the bezel margin should close the launcher. It was implemented incorrectly and is now working. verified with a new test! 2. New Ux Behavior: Flinging the launcher down from any state should close it. Verified with a new test! TBR=newcomer@chromium.org (cherry picked from commit 63b5efdda6e5c9b491880e15c79ca7157a7fbb21) Bug: 742542 Change-Id: I244dbb841d030f8028431de9ef50b34cb4566d54 Reviewed-on: https://chromium-review.googlesource.com/629197 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#496776} Reviewed-on: https://chromium-review.googlesource.com/642467 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#987} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/35747ab75f6dac0eadc542afc5640cf95f69b12f/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/35747ab75f6dac0eadc542afc5640cf95f69b12f/ui/app_list/views/app_list_view.cc
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by newcomer@chromium.org
, Aug 23 2017