DCHECK_CURRENTLY_ON misleading in some offline_pages tests |
||
Issue descriptionDCHECK_CURRENTLY_ON will succeed for any thread label when run with TestBrowserThreadBundle with no additional threads because TestBrowserThreadBundle runs everything in one thread and MessageLoop. c/b/a/offline_pages/offline_page_request_job_unittest.cc and c/b/a/offline_pages/prerendering_loader_unittest.cc both use these DCHECKs.
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1804cb29107851a63ca12af6215557d5cb301c6a commit 1804cb29107851a63ca12af6215557d5cb301c6a Author: Jian Li <jianli@chromium.org> Date: Mon Jul 24 20:54:05 2017 Use real IO thread for OfflinePageRequestJobTest, PrerenderingLoaderTest BUG= 742541 Change-Id: I5d499ffa23ed81f8005b3c62e05f0262d2894e93 Reviewed-on: https://chromium-review.googlesource.com/577982 Reviewed-by: Dmitry Titov <dimich@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#489068} [modify] https://crrev.com/1804cb29107851a63ca12af6215557d5cb301c6a/chrome/browser/offline_pages/offline_page_request_job_unittest.cc [modify] https://crrev.com/1804cb29107851a63ca12af6215557d5cb301c6a/chrome/browser/offline_pages/prerendering_loader_unittest.cc
,
Jul 24 2017
Switched to using real IO thread. |
||
►
Sign in to add a comment |
||
Comment 1 by dim...@chromium.org
, Jul 19 2017Status: Assigned (was: Unconfirmed)