content_browsertests failing on chromium.memory/Linux TSan Tests Builders failed on: Linux TSan Tests https://build.chromium.org/p/chromium.memory/builders/Linux%20TSan%20Tests Earliest build: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20TSan%20Tests/8814 Most recent build: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20TSan%20Tests/8825 Possible suspect change: https://chromium.googlesource.com/chromium/src/+/28c8676d89927c00b9e64dfdb7681027d93a37df
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44c7177cb8f4e5e708942709b4dc7bd81dc85f50 commit 44c7177cb8f4e5e708942709b4dc7bd81dc85f50 Author: Quinten Yearsley <qyearsley@google.com> Date: Fri Jul 14 01:54:15 2017 Revert "Enable spare RenderProcessHost to be preinitialized." This reverts commit 28c8676d89927c00b9e64dfdb7681027d93a37df. Reason for revert: Linux TSanTests found a ThreadSanitizer warning that appears to likely be associated with this change. TBR: mattcary Bug: 742533 Change-Id: I5a9f462a89b11ec7c4d5106ae2407505ab017960 Reviewed-on: https://chromium-review.googlesource.com/571359 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#486623} [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/chrome/browser/about_flags.cc [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/chrome/browser/android/warmup_manager.cc [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/chrome/browser/flag_descriptions.h [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/content/browser/browser_context.cc [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/content/browser/frame_host/render_frame_host_manager.cc [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/content/browser/renderer_host/render_process_host_browsertest.cc [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/content/browser/renderer_host/render_process_host_unittest.cc [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/content/public/browser/render_process_host.h [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/content/public/test/mock_render_process_host.cc [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/content/public/test/mock_render_process_host.h [modify] https://crrev.com/44c7177cb8f4e5e708942709b4dc7bd81dc85f50/tools/metrics/histograms/enums.xml
TSan bot is now green after revert; please reland change after looking at the ThreadSanitizer warnings, e.g. SUMMARY: ThreadSanitizer: data race content/public/common/content_client.cc:22:24 in SetBrowser ... SUMMARY: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) content/test/test_content_browser_client.cc:16:55 in content::TestContentBrowserClient::~TestContentBrowserClient() https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_TSan_Tests%2F8814%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests%2F0%2Fstdout
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab08362cb469d48e79bee165b56d7bf962382490 commit ab08362cb469d48e79bee165b56d7bf962382490 Author: Benoit Lize <lizeb@chromium.org> Date: Wed Jul 19 14:50:54 2017 Reland "Enable spare RenderProcessHost to be preinitialized."" Reason: fixed test. This reverts commit 44c7177cb8f4e5e708942709b4dc7bd81dc85f50. Original CL by mattcary@chromium.org Original CL: > Enable spare RenderProcessHost to be preinitialized. > Enables a preinitialization of an unbound RenderProcessHost, and refactors > RenderProcessHost creation to allow that to be used where appropriate. > BUG= 730587 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=qyearsley@chromium.org,mattcary@chromium.org,tedchoc@chromium.org Bug: 730587 , 742533 Change-Id: I61c37031e2872a5f9817543418cd30f253e70e4b Reviewed-on: https://chromium-review.googlesource.com/575988 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487859} [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/chrome/browser/about_flags.cc [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/chrome/browser/android/warmup_manager.cc [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/chrome/browser/flag_descriptions.h [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/content/browser/browser_context.cc [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/content/browser/frame_host/render_frame_host_manager.cc [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/content/browser/renderer_host/render_process_host_browsertest.cc [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/content/browser/renderer_host/render_process_host_unittest.cc [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/content/public/browser/render_process_host.h [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/content/public/test/mock_render_process_host.cc [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/content/public/test/mock_render_process_host.h [modify] https://crrev.com/ab08362cb469d48e79bee165b56d7bf962382490/tools/metrics/histograms/enums.xml
Comment 1 by bugdroid1@chromium.org
, Jul 14 2017