New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742528 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Git



Sign in to add a comment

Code search should link to master branch / HEAD of gitiles view.

Project Member Reported by scheib@chromium.org, Jul 13 2017

Issue description

What steps will reproduce the problem?
(1) View code in https://chromium.googlesource.com
(2) Click 'View in', 'Git'

What is the expected result?

  Viewing most recent files in Git. URLs use master branch.

What happens instead?

  URLs in gitile use a hash to a specific version, will become out of date.


This will help when navigating code and sharing links. E.g. sharing links to documentation, or a class. I believe it is less common to need to share a URL to a pinned specific version, and when necessary folks will do that by viewing a git history from gitiles.

Note that internal search uses head, not pinned hashes.


 
2-gitiles-loaded-at-a-hash.png
158 KB View Download
1-code-search-selecting-view-in-git.png
184 KB View Download

Comment 1 by scheib@chromium.org, Jul 13 2017

Description: Show this description

Comment 2 by emso@chromium.org, Aug 14 2017

Labels: Git frontend
Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 14

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Owner: orodley@chromium.org
Status: Started (was: Available)
Status: Fixed (was: Started)

Sign in to add a comment