Another opportunity to be more aggressive when collapsing is for console messages who only differ by their network request.

DevTools only makes use of the message.request.requestMethod during formatting.  Thus, users might see sequential messages which look the same but aren't collapsed.

Deleted: differentRequestMessages.png 16.6 KB

	differentRequestMessages.png 16.6 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5a5eaa5461ca76aba539c97335df2f98629ea49

commit d5a5eaa5461ca76aba539c97335df2f98629ea49
Author: Erik Luo <luoe@chromium.org>
Date: Wed Jul 26 01:18:30 2017

DevTools: treat similar console error-type parameters as equal

DevTools collapses sequential messages with a repeat count if they are the same.
This CL modifies the equality check to be more aggressive when collapsing.
Thrown errors in the console with different exceptionIds will now be treated as
equal.

Bug:  742526 
Change-Id: I530a73593f2dc1e9e38423f8cc44ceec2bd49ccc
Reviewed-on: https://chromium-review.googlesource.com/580364
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489510}
[modify] https://crrev.com/d5a5eaa5461ca76aba539c97335df2f98629ea49/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
[modify] https://crrev.com/d5a5eaa5461ca76aba539c97335df2f98629ea49/third_party/WebKit/LayoutTests/inspector/console/console-repeat-count-expected.txt
[modify] https://crrev.com/d5a5eaa5461ca76aba539c97335df2f98629ea49/third_party/WebKit/LayoutTests/inspector/console/console-repeat-count.html
[modify] https://crrev.com/d5a5eaa5461ca76aba539c97335df2f98629ea49/third_party/WebKit/LayoutTests/inspector/console/console-revoke-error-expected.txt
[modify] https://crrev.com/d5a5eaa5461ca76aba539c97335df2f98629ea49/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1236993289b3a34ac29c6d18fbd31273eee86c73

commit 1236993289b3a34ac29c6d18fbd31273eee86c73
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Wed Jul 26 09:59:52 2017

Revert "DevTools: treat similar console error-type parameters as equal"

This reverts commit d5a5eaa5461ca76aba539c97335df2f98629ea49.

Reason for revert: This seems like causing a test failure at: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/3278

Original change's description:
> DevTools: treat similar console error-type parameters as equal
> 
> DevTools collapses sequential messages with a repeat count if they are the same.
> This CL modifies the equality check to be more aggressive when collapsing.
> Thrown errors in the console with different exceptionIds will now be treated as
> equal.
> 
> Bug:  742526 
> Change-Id: I530a73593f2dc1e9e38423f8cc44ceec2bd49ccc
> Reviewed-on: https://chromium-review.googlesource.com/580364
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Erik Luo <luoe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#489510}

TBR=dgozman@chromium.org,luoe@chromium.org

Change-Id: I19cc787c8ad6263f34cb70f7c833f687862e3c97
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  742526 
Reviewed-on: https://chromium-review.googlesource.com/586307
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489596}
[modify] https://crrev.com/1236993289b3a34ac29c6d18fbd31273eee86c73/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
[modify] https://crrev.com/1236993289b3a34ac29c6d18fbd31273eee86c73/third_party/WebKit/LayoutTests/inspector/console/console-repeat-count-expected.txt
[modify] https://crrev.com/1236993289b3a34ac29c6d18fbd31273eee86c73/third_party/WebKit/LayoutTests/inspector/console/console-repeat-count.html
[modify] https://crrev.com/1236993289b3a34ac29c6d18fbd31273eee86c73/third_party/WebKit/LayoutTests/inspector/console/console-revoke-error-expected.txt
[modify] https://crrev.com/1236993289b3a34ac29c6d18fbd31273eee86c73/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d11ccae80b56300d4eac0133b4498d63dc7433f

commit 0d11ccae80b56300d4eac0133b4498d63dc7433f
Author: Pavel Kalinnikov <pkalinnikov@chromium.org>
Date: Wed Jul 26 10:56:42 2017

Revert "DevTools: treat similar console error-type parameters as equal"

This reverts commit d5a5eaa5461ca76aba539c97335df2f98629ea49.

Reason for revert: console-repeat-count test fails on "WebKit Mac10.11 (dbg)" builder: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/9635

Original change's description:
> DevTools: treat similar console error-type parameters as equal
> 
> DevTools collapses sequential messages with a repeat count if they are the same.
> This CL modifies the equality check to be more aggressive when collapsing.
> Thrown errors in the console with different exceptionIds will now be treated as
> equal.
> 
> Bug:  742526 
> Change-Id: I530a73593f2dc1e9e38423f8cc44ceec2bd49ccc
> Reviewed-on: https://chromium-review.googlesource.com/580364
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Erik Luo <luoe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#489510}

TBR=dgozman@chromium.org,luoe@chromium.org

Change-Id: I388accecd3d4dd463486f133e7a8e77bafbb0862
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  742526 
Reviewed-on: https://chromium-review.googlesource.com/586507
Reviewed-by: Pavel Kalinnikov <pkalinnikov@chromium.org>
Commit-Queue: Pavel Kalinnikov <pkalinnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489604}

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/915e77efa3995820b4dbcac58359918179b60399

commit 915e77efa3995820b4dbcac58359918179b60399
Author: Erik Luo <luoe@chromium.org>
Date: Tue Aug 01 08:25:51 2017

Reland of DevTools: treat similar console error-type parameters as equal

DevTools collapses sequential messages with a repeat count if they are the same.
This CL modifies the equality check to be more aggressive when collapsing.
Thrown errors in the console with different exceptionIds will now be treated as
equal.

We also need to avoid altering message.parameters in _format() so that equality
checks do not flake.
This is a reland of: https://chromium-review.googlesource.com/c/580364/

Bug:  742526 
Change-Id: I49450482af8fb129a662f3b84765d07e99b9723b
Reviewed-on: https://chromium-review.googlesource.com/590931
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490916}
[modify] https://crrev.com/915e77efa3995820b4dbcac58359918179b60399/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
[modify] https://crrev.com/915e77efa3995820b4dbcac58359918179b60399/third_party/WebKit/LayoutTests/inspector/console/console-repeat-count-expected.txt
[modify] https://crrev.com/915e77efa3995820b4dbcac58359918179b60399/third_party/WebKit/LayoutTests/inspector/console/console-repeat-count.html
[modify] https://crrev.com/915e77efa3995820b4dbcac58359918179b60399/third_party/WebKit/LayoutTests/inspector/console/console-revoke-error-expected.txt
[modify] https://crrev.com/915e77efa3995820b4dbcac58359918179b60399/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/915e77efa3995820b4dbcac58359918179b60399/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js