config_service: Stop extra ajax calls on front page. |
||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? (1) Go to luci-config.appspot.com/newui (2) Sign in What is the expected result? One ajax call is made, so the list of config sets is only loaded once What happens instead? An ajax call is automatically made before the UI registers the user's credentials, so the list of config sets is loaded, and then when the user is signed in another ajax call is made and the list changes. It would be better if the ajax call only happened once the user is signed in, if possible.
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/bb47aeb0a0fdf3d96bcb7c31b7b332bd969dbce6 commit bb47aeb0a0fdf3d96bcb7c31b7b332bd969dbce6 Author: cwpayton <cwpayton@google.com> Date: Tue Jul 18 21:38:11 2017 config_service: Fixed multiple ajax requests in the front page while the page determines whether a user is signed in. This CL disables the auto ajax requests and is instead triggered by the loading of the google auth API and user object. BUG= 742522 Review-Url: https://codereview.chromium.org/2980973002 [modify] https://crrev.com/bb47aeb0a0fdf3d96bcb7c31b7b332bd969dbce6/appengine/config_service/ui/common/auth-signin.html [modify] https://crrev.com/bb47aeb0a0fdf3d96bcb7c31b7b332bd969dbce6/appengine/config_service/ui/src/config-ui/config-ui.html [modify] https://crrev.com/bb47aeb0a0fdf3d96bcb7c31b7b332bd969dbce6/appengine/config_service/ui/src/config-ui/front-page.html
,
Jul 18 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by sheriffbot@chromium.org
, Jul 14 2017