[iOS] Should not send ImpressionsTilDismiss in bookmarks if logs with settings |
||
Issue descriptionScenario: on iPad, no logged in + Open a tab on bookmarks (with the new sign-in promo) + Open the settings on top of it + Sign-in What happens: the sign-in promo view in the bookmark is removed and MobileSignInPromo.BookmarkManager.ImpressionsTilDismiss is sent. Expected result: MobileSignInPromo.BookmarkManager.ImpressionsTilDismiss should not be sent since the user didn't dismiss the sign-in promo view.
,
Jul 13 2017
Interesting, good catch. This is pretty low priority though (iPad only, and kind of an edge case). Let's fix the other metrics issues first.
,
Jul 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74765b491b95983786e51bd187bb7aa1c31a04c9 commit 74765b491b95983786e51bd187bb7aa1c31a04c9 Author: Jérôme Lebel <jlebel@chromium.org> Date: Mon Jul 17 13:08:30 2017 Don't send dismiss histogram if the user logged in On iPad, the user can show the bookmarks with the sign-in promo and open the settings. If they sign in with the settings, then the sign-in promo will be removed from the bookmarks. The mediator from the bookmarks should not send the dismiss histogram. To avoid this problem, the sign-in promo view mediator needs to check if the user is logged in before sending the dismiss histogram. Bug: 742514 Change-Id: Id5c189e68a06e82874ef487155831593911a9ef4 Reviewed-on: https://chromium-review.googlesource.com/567508 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#487061} [modify] https://crrev.com/74765b491b95983786e51bd187bb7aa1c31a04c9/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.mm
,
Jul 17 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by jlebel@chromium.org
, Jul 13 2017