New issue
Advanced search Search tips

Issue 742509 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Headset insertion after entering VR toggles off VR mode.

Project Member Reported by mthiesse@chromium.org, Jul 13 2017

Issue description

We get paused/resumed when the NFC scan happens while already in VR, which was causing us erroneously to exit VR mode.
 
Labels: -M-61 M-62
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9c23f65984eaaac896b56d17ac0fe1fe621bca7

commit f9c23f65984eaaac896b56d17ac0fe1fe621bca7
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Jul 14 16:27:52 2017

VR: Don't attempt to cancel VR entry if we're already in VR.

Headset NFC scan can pause and resume (without stopping) us while
we're already in VR, so we stay in VR while this is happening.
However, when we get paused we want to cancel VR entry so we don't
enter VR while paused. This CL just adds a check to see if we're in
VR before attempting to cancel entry.

Bug:  742509 
Change-Id: Ib0cdac3c7e10e5206410835f949f318c73e9349f
Reviewed-on: https://chromium-review.googlesource.com/570742
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486769}
[modify] https://crrev.com/f9c23f65984eaaac896b56d17ac0fe1fe621bca7/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Status: Fixed (was: Started)
Labels: -M-62 M-61

Sign in to add a comment