New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 742505 link

Starred by 1 user
Status: Started
Owner:
█ holte@chromium.org
Last visit > 30 days ago
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

More MetricsService/Log logic should be moved to MetricsProviders

Project Member Reported by holte@chromium.org, Jul 13 2017 
MetricsService/Log still has a fair amount of code for recording particular bits of data into each metrics log.  As much as possible, we should move these into opaque metrics providers, to narrow the focus of these objects. This will be particularly useful for making it easier to eventually move the MetricsService into a separate process.

Comment 1 by holte@chromium.org, Jul 13 2017

Components: Internals>Metrics
Labels: -Type-Bug Type-Task

Comment 2 by holte@chromium.org, Aug 3 2017

Owner: holte@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e9db0ca5f5a6062cc1d6e141725687e5cae2409

commit 8e9db0ca5f5a6062cc1d6e141725687e5cae2409
Author: Steven Holte <holte@google.com>
Date: Fri Aug 11 01:20:08 2017

Add InstallDate and EnabledMetricsState to StateManagerMetricsProvider.

Bug: 742505
Change-Id: I0f84d1238f9731cdf3f17441aaadcf3b1c35f1f4
Reviewed-on: https://chromium-review.googlesource.com/600834
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493631}
[modify] https://crrev.com/8e9db0ca5f5a6062cc1d6e141725687e5cae2409/components/metrics/metrics_log.cc
[modify] https://crrev.com/8e9db0ca5f5a6062cc1d6e141725687e5cae2409/components/metrics/metrics_log.h
[modify] https://crrev.com/8e9db0ca5f5a6062cc1d6e141725687e5cae2409/components/metrics/metrics_log_unittest.cc
[modify] https://crrev.com/8e9db0ca5f5a6062cc1d6e141725687e5cae2409/components/metrics/metrics_service.cc
[modify] https://crrev.com/8e9db0ca5f5a6062cc1d6e141725687e5cae2409/components/metrics/metrics_service.h
[modify] https://crrev.com/8e9db0ca5f5a6062cc1d6e141725687e5cae2409/components/metrics/metrics_service_unittest.cc
[modify] https://crrev.com/8e9db0ca5f5a6062cc1d6e141725687e5cae2409/components/metrics/metrics_state_manager.cc
[modify] https://crrev.com/8e9db0ca5f5a6062cc1d6e141725687e5cae2409/components/metrics/metrics_state_manager.h
[modify] https://crrev.com/8e9db0ca5f5a6062cc1d6e141725687e5cae2409/components/metrics/metrics_state_manager_unittest.cc
[modify] https://crrev.com/8e9db0ca5f5a6062cc1d6e141725687e5cae2409/ios/chrome/today_extension/today_metrics_logger.mm
►

Sign in to add a comment