New issue
Advanced search Search tips

Issue 742503 link

Starred by 1 user
Status: Fixed
Owner:
kristip...@chromium.org
Closed: Jul 2017
Cc:
jsb...@chromium.org
dmu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

IndexedDBDispatcherHostTest.*While* tests are flaky

Project Member Reported by jsb...@chromium.org, Jul 13 2017 
Flakiness dashboard:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_unittests&tests=IndexedDBDispatcherHostTest

These tests (new in r#484755) are flaky on all platforms:

IndexedDBDispatcherHostTest.AbortTransactionsWhileDoingTransaction
IndexedDBDispatcherHostTest.CompactDatabaseWhileDoingTransaction
IndexedDBDispatcherHostTest.CompactDatabaseWhileUpgrading
IndexedDBDispatcherHostTest.AbortTransactionsWhileUpgrading

I'm not seeing failure logs, but a CL of mine failed with this:


I   93.849s run_tests_on_device(061d1859f0ec887c)  [ RUN      ] IndexedDBDispatcherHostTest.CompactDatabaseWhileDoingTransaction
I   93.849s run_tests_on_device(061d1859f0ec887c)  unknown file: Failure
I   93.849s run_tests_on_device(061d1859f0ec887c)  Uninteresting mock function call - returning directly.
I   93.849s run_tests_on_device(061d1859f0ec887c)      Function call: ForcedClose()
I   93.849s run_tests_on_device(061d1859f0ec887c)  [  FAILED  ] IndexedDBDispatcherHostTest.CompactDatabaseWhileDoingTransaction (109 ms)
I   93.849s run_tests_on_device(061d1859f0ec887c)  [ RUN      ] IndexedDBDispatcherHostTest.CompactDatabaseWhileUpgrading
I   93.849s run_tests_on_device(061d1859f0ec887c)  unknown file: Failure
I   93.849s run_tests_on_device(061d1859f0ec887c)  Uninteresting mock function call - returning directly.
I   93.849s run_tests_on_device(061d1859f0ec887c)      Function call: ForcedClose()
I   93.849s run_tests_on_device(061d1859f0ec887c)  [  FAILED  ] IndexedDBDispatcherHostTest.CompactDatabaseWhileUpgrading (76 ms)
I   93.849s run_tests_on_device(061d1859f0ec887c)  [ RUN      ] IndexedDBDispatcherHostTest.AbortTransactionsAfterCompletingTransaction
I   93.849s run_tests_on_device(061d1859f0ec887c)  [       OK ] IndexedDBDispatcherHostTest.AbortTransactionsAfterCompletingTransaction (102 ms)
I   93.849s run_tests_on_device(061d1859f0ec887c)  [ RUN      ] IndexedDBDispatcherHostTest.AbortTransactionsWhileDoingTransaction
I   93.849s run_tests_on_device(061d1859f0ec887c)  unknown file: Failure
I   93.849s run_tests_on_device(061d1859f0ec887c)  Uninteresting mock function call - returning directly.
I   93.849s run_tests_on_device(061d1859f0ec887c)      Function call: ForcedClose()
I   93.849s run_tests_on_device(061d1859f0ec887c)  [  FAILED  ] IndexedDBDispatcherHostTest.AbortTransactionsWhileDoingTransaction (85 ms)
I   93.849s run_tests_on_device(061d1859f0ec887c)  [ RUN      ] IndexedDBDispatcherHostTest.AbortTransactionsWhileUpgrading
I   93.850s run_tests_on_device(061d1859f0ec887c)  unknown file: Failure
I   93.850s run_tests_on_device(061d1859f0ec887c)  Uninteresting mock function call - returning directly.
I   93.850s run_tests_on_device(061d1859f0ec887c)      Function call: ForcedClose()
I   93.850s run_tests_on_device(061d1859f0ec887c)  [  FAILED  ] IndexedDBDispatcherHostTest.AbortTransactionsWhileUpgrading (88 ms)

Comment 1 by dmu...@chromium.org, Jul 13 2017 

Hm - let's disable these tests for now.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/140cb33e8a763d2fae405e873541e5a1b73c3f2d

commit 140cb33e8a763d2fae405e873541e5a1b73c3f2d
Author: Daniel Murphy <dmurph@chromium.org>
Date: Thu Jul 13 22:48:01 2017

[IndexedDB] Disabling flaky tests

R: jsbell@chromium.org
Bug:  742503 
Change-Id: I57bb42b891840c4100956f264e1dd19c4b2b1e8e
Reviewed-on: https://chromium-review.googlesource.com/570951
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486500}
[modify] https://crrev.com/140cb33e8a763d2fae405e873541e5a1b73c3f2d/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a32b969b444783e8d468b4dcc20890d233cca57

commit 0a32b969b444783e8d468b4dcc20890d233cca57
Author: kristipark <kristipark@chromium.org>
Date: Fri Jul 14 23:14:36 2017

[IndexedDB] Fixed flaky "While" tests in dispatcher host

The connection is force closed when a transaction is aborted
mid-execution. The "While" tests failed to catch this, so
added another EXPECT_CALL for ForcedClose().

Bug:  742503 
Change-Id: Id56a5cced876bc8a4d02c60a29e20471085a29ac
Reviewed-on: https://chromium-review.googlesource.com/571197
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486925}
[modify] https://crrev.com/0a32b969b444783e8d468b4dcc20890d233cca57/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc

Comment 4 by kristip...@chromium.org, Jul 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment