Issue metadata
Sign in to add a comment
|
19.9% regression in startup.warm.blank_page at 485621:485695 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 13 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8974158329233740224
,
Jul 13 2017
=== Auto-CCing suspected CL author sdy@chromium.org === Hi sdy@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Sidney San Martín Commit : a20a025fb10592190b5b3bc90fd627c45c76676a Date : Tue Jul 11 18:39:06 2017 Subject: Enable ShouldUseFullSizeContentView(). Bisect Details Configuration: mac_10_11_perf_bisect Benchmark : startup.warm.blank_page Metric : first_main_frame_load_time/first_main_frame_load_time Revision Result N chromium@485620 333.792 +- 10.8709 6 good chromium@485658 346.292 +- 27.2934 6 good chromium@485677 342.667 +- 25.811 6 good chromium@485680 343.583 +- 14.687 6 good chromium@485681 347.833 +- 25.7188 6 good chromium@485682 405.292 +- 28.9599 6 bad <-- chromium@485686 402.583 +- 22.3849 6 bad chromium@485695 403.208 +- 25.6744 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=5 --also-run-disabled-tests startup.warm.blank_page More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8974158329233740224 For feedback, file a bug with component Speed>Bisection
,
Jul 13 2017
Issue 742470 has been merged into this issue.
,
Jul 14 2017
The Auto Layout perf regression of issue 706931 seems to be back :/. Assuming it's actually specific to 10.11, my preferred response right now would be bumping the required OS for ShouldUseFullSizeContentView() to 10.12. Thoughts?
,
Jul 14 2017
>= 10.12 sounds okay to me.
,
Jul 14 2017
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec030bde9b5ebbd500fe769af1ac6a47e6baa5c0 commit ec030bde9b5ebbd500fe769af1ac6a47e6baa5c0 Author: Sidney San Martín <sdy@chromium.org> Date: Fri Jul 14 19:20:53 2017 Require 10.12 for ShouldUseFullSizeContentView(). Bug: 742472 Change-Id: I82a02072b308d7f7753b9a5274465cdba7c64bbd Reviewed-on: https://chromium-review.googlesource.com/571420 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martin <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#486838} [modify] https://crrev.com/ec030bde9b5ebbd500fe769af1ac6a47e6baa5c0/chrome/browser/ui/cocoa/browser_window_layout.mm
,
Jul 14 2017
,
Jul 24 2017
(Trying to get this moved off the perf sheriff backlog.) open_tabs_time and first_main_frame_load_time seem to have recovered after the above CL (see [1]) which is awesome! I'm going to assume it is okay to mark this fixed now? Also a couple of unrelated regressions seem to have ended up on this bug so I'm going re-triage them. [1]: See https://chromeperf.appspot.com/group_report?sid=874ef6b4dcab3183b82508ace4969c6306b93235a723ad5f61c49557166ec2ba
,
Jul 24 2017
The performance characteristics of the thing that led to this regression (macOS Auto Layout) are still not well-understood, so I'm working to turn it back off in the next couple of weeks :).
,
Jul 27 2017
,
Jul 27 2017
Issue 745915 has been merged into this issue.
,
Jul 27 2017
Issue 745922 has been merged into this issue.
,
Jul 28 2017
Issue 745909 has been merged into this issue.
,
Jul 28 2017
Issue 745929 has been merged into this issue. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 13 2017