Issue metadata
Sign in to add a comment
|
4.3%-8.8% regression in thread_times.key_mobile_sites_smooth at 485734:485808 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 13 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8974158368616419152
,
Jul 14 2017
=== Auto-CCing suspected CL author sunnyps@chromium.org === Hi sunnyps@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Sunny Sachanandani Commit : 7a4f2242badc95b109bb551e2ec1ebcebc2ff0d2 Date : Wed Jul 12 02:27:18 2017 Subject: cc: Add crash key for debugging BeginMainFrame renderer hang. Bisect Details Configuration: android_webview_arm64_aosp_perf_bisect Benchmark : thread_times.key_mobile_sites_smooth Metric : thread_renderer_compositor_cpu_time_per_frame/thread_renderer_compositor_cpu_time_per_frame Change : 8.77% | 2.45918606043 -> 2.67490875792 Revision Result N chromium@485733 2.45919 +- 0.0667958 6 good chromium@485771 2.48715 +- 0.0530182 6 good chromium@485790 2.48026 +- 0.0264558 6 good chromium@485799 2.48472 +- 0.0302735 6 good chromium@485801 2.47875 +- 0.0249353 6 good chromium@485802 2.67526 +- 0.0545441 6 bad <-- chromium@485804 2.67284 +- 0.0472649 6 bad chromium@485808 2.67491 +- 0.059886 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.key_mobile_sites_smooth More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8974158368616419152 For feedback, file a bug with component Speed>Bisection
,
Jul 14 2017
The crash key is temporary for debugging a renderer hang. I'll revert this before the branch so that we don't see the regression on dev channel.
,
Jul 18 2017
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1efdc3eec28f62fab81f4d9f6c224302675a7d5 commit a1efdc3eec28f62fab81f4d9f6c224302675a7d5 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Thu Jul 20 00:18:59 2017 cc: Remove crash logging for BeginMainFrame hang. This regressed some benchmarks and also accounts for a few percent of power consumption. Revert "cc: Add crash key for debugging BeginMainFrame renderer hang." This reverts commit 7a4f2242badc95b109bb551e2ec1ebcebc2ff0d2. Revert "cc: Dump more state in begin main frame hang crash key." This reverts commit 057d5553e4524a7726b2e7d5ecfef85289379000. TBR=brianderson,rsesek,alokp,scottmg,brucedawson BUG=622080, 744740 , 742471 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib96e7ca083c4ce3a22890b8d6e822f57dd391ef7 Reviewed-on: https://chromium-review.googlesource.com/578066 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#488060} [modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/android_webview/common/crash_reporter/crash_keys.cc [modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/cc/scheduler/scheduler.cc [modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/cc/scheduler/scheduler.h [modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/cc/scheduler/scheduler_state_machine.cc [modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/cc/scheduler/scheduler_state_machine.h [modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/chrome/app/chrome_crash_reporter_client_win.cc [modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/chrome/common/crash_keys.cc [modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/chrome/common/crash_keys.h [modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/chromecast/crash/cast_crash_keys.cc
,
Jul 20 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 13 2017