android fullscreen video doesn't play |
||
Issue descriptionChrome Version: starting at 28c5a8185d81adc5 OS: Android What steps will reproduce the problem? (1) go to storage.googleapis.com/watk-public/v (2) select buck360p_h264.mp4, start playback (3) enter fullscreen. it'll probably stop playing. this is where we switch to using overlays for video. (4) if not, exiting almost always breaks it. i did a bisect, and this seems to be where it starts: 28c5a8185d81 Decouple cc::Surface from cc::CompositorFrameSinkSupport. of interest, it only seems to break when we use overlays for video. if we stick to entirely non-overlay playback, then it works fine. i've got a feeling that GpuVideoDecoder isn't getting a release callback from the mailbox, but i'll confirm that.
,
Jul 13 2017
yes, some VideoFrames are not being released when we switch to overlay video. the number seems to vary. sometimes we'll have two out of four or five returned, and video keeps going. other times, we'll drop to 0 or 1, and it stops. all of them should be coming back. these callbacks happen when VideoFrame is destructed (video_frame.cc, |mailbox_holders_release_cb_|). There's a callback ( https://cs.chromium.org/chromium/src/cc/resources/video_resource_updater.cc?rcl=c518bad7dc834521147fa639eb3b38e8945d60c6&l=690 ) that holds the VideoFrame until the cc returns the resource for it. probably, the cc isn't returning the resources all the time. maybe if the frame is dropped or something? please let me know if i can help track this down. thanks -fl
,
Jul 13 2017
ToT: i'll check. it was yesterday afternoon.
,
Jul 13 2017
In particular I would've expected this CL to fix the problem: https://chromium-review.googlesource.com/c/558472/
,
Jul 13 2017
Ooops I mean this CL: https://chromium-review.googlesource.com/566332
,
Jul 13 2017
i've not managed to get a ToT that doesn't crash on startup, unfortunately. will go back to c#5 exactly and give it a try. i don't think that was in my bisect range, so hopefully so.
,
Jul 13 2017
yes, it works! thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by fsam...@chromium.org
, Jul 13 2017