New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 742430 link

Starred by 2 users
Status: Fixed
Owner:
wychen@chromium.org
Closed: Sep 2017
Cc:
yus...@chromium.org
█ mariakho...@chromium.org
jbudorick@chromium.org
thildebr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

UrlOverridingTest.testOpenWindowFromUserGesture failing flakily on K Tablet

Project Member Reported by jbudorick@chromium.org, Jul 13 2017 
Failing with:

java.lang.AssertionError: expected:<1> but was:<2>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.junit.Assert.assertEquals(Assert.java:631)
	at org.chromium.chrome.browser.externalnav.UrlOverridingTest.loadUrlAndWaitForIntentUrl(UrlOverridingTest.java:249)
	at org.chromium.chrome.browser.externalnav.UrlOverridingTest.testOpenWindowFromUserGesture(UrlOverridingTest.java:365)
        ...

+cc folks who have done recent-ish work in externalnav. Not sure when this started.

I'm adding @RetryOnFailure momentarily.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8aee8166f3e2d569971a5866734cc017b52483eb

commit 8aee8166f3e2d569971a5866734cc017b52483eb
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Jul 14 00:58:29 2017

[android] Add @RetryOnFailure to UrlOverridingTest.

Failing flakily on KitKat Tablet Tester.

TBR=hartmanng@chromium.org

Bug:  742430 
Change-Id: Ideccbdb16ae9e5d8e9a25e44cbc07102b21076f1
Reviewed-on: https://chromium-review.googlesource.com/570186
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486564}
[modify] https://crrev.com/8aee8166f3e2d569971a5866734cc017b52483eb/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java

Comment 3 by dgn@chromium.org, Sep 4 2017

Cc: yus...@chromium.org
Owner: wychen@chromium.org
I'm going to disable the test, it's flaking on other bots too now, failing most of the time. Running the test locally, it needs 2 or 3 tries to pass on a Nexus 9.

I'm not sure what recently made it worse. Trace is the same as previously reported.

wychen@, could you please have a look? You seem to have changes assertions in this test some time ago, maybe you could find more easily what's going on. Also cc'ing yusufo@, for touching at //../externalnav last :)

Comment 4 by dgn@chromium.org, Sep 4 2017

Cc: jbudorick@chromium.org
 Issue 758119  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50e71c6c07a658505ee03889f08dad07c2a1a1b8

commit 50e71c6c07a658505ee03889f08dad07c2a1a1b8
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Mon Sep 04 14:45:58 2017

Disable UrlOverridingTest.testOpenWindowFromUserGesture

Too flaky

TBR=wychen@chromium.org

Bug:  742430 
Change-Id: I7facbe0b9efa0622eb9b2972a1297b224aa28c6d
Reviewed-on: https://chromium-review.googlesource.com/649206
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499499}
[modify] https://crrev.com/50e71c6c07a658505ee03889f08dad07c2a1a1b8/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java

Comment 6 by wychen@chromium.org, Sep 14 2017 

UrlOverridingTest.testOpenWindowFromUserGesture can pass on phones as well, not just tablets. Looks like the restriction was there when this test was added in https://chrome-internal-review.googlesource.com/213807.

Comment 7 by wychen@chromium.org, Sep 15 2017 

Nicolas, could you help verify this CL can fix the flakiness? I couldn't make it fail on my N5. Thanks!
https://chromium-review.googlesource.com/c/chromium/src/+/667790

Comment 8 by wychen@chromium.org, Sep 15 2017

Status: Started (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01c6c89f1831723aa356ab66f7288b11ff143551

commit 01c6c89f1831723aa356ab66f7288b11ff143551
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Thu Sep 21 00:39:52 2017

Enable UrlOverridingTest.testOpenWindowFromUserGesture

Revised the assertion to fix the flakiness.
Enabled on phones as well.
Also some minor clean up.

Bug:  742430 
Change-Id: I2e360a1ef69c5ae88cc87d9eefcb50d67b5b597b
Reviewed-on: https://chromium-review.googlesource.com/667790
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503296}
[modify] https://crrev.com/01c6c89f1831723aa356ab66f7288b11ff143551/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java

Comment 10 by wychen@chromium.org, Sep 21 2017

Status: Fixed (was: Started)
Should be fixed. Let's see how it behaves on bots.
►

Sign in to add a comment