New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742426 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

remove/uninstall a suggested app may leave a vacant tile on all apps page

Project Member Reported by warx@chromium.org, Jul 13 2017

Issue description

should be a quick fix, may update the view when app list model's search results have a change.
 
Screenshot 2017-07-13 at 10.23.35.png
636 KB View Download

Comment 1 by warx@chromium.org, Jul 14 2017

On tablet mode, suggested apps are not shown. That is the same root cause.

Reviewed on https://chromium-review.googlesource.com/c/571020/
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee07c7f98b7793684650d6fc5d05f2096c71332c

commit ee07c7f98b7793684650d6fc5d05f2096c71332c
Author: Qiang Xu <warx@chromium.org>
Date: Mon Jul 17 17:59:05 2017

app_list: enable SuggestionsContainerView::DoUpdate for STATE_APPS state

changes:
SuggestionsContainerView is moved from StartPageView nested class in
go/croscl/548972 to support being added to STATE_APPS state. We should
enable DoUpdate() method for STATE_APPS state.

Bug:  742426 
TEST: test that bug is fixed
Change-Id: I5eeabcb52f77ad6ddf34fa1ea75a7f9fc1f162d3
Reviewed-on: https://chromium-review.googlesource.com/571020
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487154}
[modify] https://crrev.com/ee07c7f98b7793684650d6fc5d05f2096c71332c/ui/app_list/views/suggestions_container_view.cc

Comment 3 by warx@chromium.org, Jul 17 2017

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment