New issue
Advanced search Search tips

Issue 742422 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 741956



Sign in to add a comment

TEMP directory are occasionally removed during telemetry_perf_unittests run

Project Member Reported by nedngu...@google.com, Jul 13 2017

Issue description

Example: https://chromium-swarm.appspot.com/task?id=375257d82681f710&refresh=10

Relevant log: 
Traceback (most recent call last):
    RunBenchmark at /b/swarm_slave/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:397
      None
    Run at /b/swarm_slave/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:295
      None
    PopulateHistogramSet at /b/swarm_slave/w/ir/third_party/catapult/telemetry/telemetry/internal/results/page_test_results.py:190
      None
    mkstemp at /usr/lib/python2.7/tempfile.py:308
      return _mkstemp_inner(dir, prefix, suffix, flags)
    _mkstemp_inner at /usr/lib/python2.7/tempfile.py:239
      fd = _os.open(file, flags, 0600)
  OSError: [Errno 2] No such file or directory: '/b/swarm_slave/w/ityCoCmk/tmprAc1qx'

 

maruel@ suspect that there is some place in Telemetry code that invoke rmtree() on the TEMP directory. I will add logging to investigate 
Blocking: 741956
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e7cda4c64d46024ad533938e34ce62624adac0c

commit 3e7cda4c64d46024ad533938e34ce62624adac0c
Author: nednguyen <nednguyen@google.com>
Date: Fri Jul 14 14:57:09 2017

[tools/perf] Log the callsites of shutil.rmtree

Bug:  742422 
Change-Id: If2f10cf42ffad4c9767571b076242388d86c11c5
Reviewed-on: https://chromium-review.googlesource.com/570679
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486757}
[modify] https://crrev.com/3e7cda4c64d46024ad533938e34ce62624adac0c/tools/perf/core/path_util.py

Project Member

Comment 4 by sheriffbot@chromium.org, Jul 14 2017

Labels: Hotlist-Google
Seems like this is no longer happening, so I am reverting the log & will mark this as Wont'Fix
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f23317b2c1be4079096585efa94047c882b402c5

commit f23317b2c1be4079096585efa94047c882b402c5
Author: nednguyen <nednguyen@google.com>
Date: Thu Aug 10 15:07:14 2017

Revert "[tools/perf] Log the callsites of shutil.rmtree"

This reverts commit 3e7cda4c64d46024ad533938e34ce62624adac0c.

Reason for revert: missing directory flake no longer happen. Removing this to make Telemetry log more readable.

Original change's description:
> [tools/perf] Log the callsites of shutil.rmtree
> 
> Bug:  742422 
> Change-Id: If2f10cf42ffad4c9767571b076242388d86c11c5
> Reviewed-on: https://chromium-review.googlesource.com/570679
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486757}

TBR=maruel@chromium.org,perezju@chromium.org,nednguyen@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  742422 
Change-Id: I1253c934ef3bc1716b1e07cdbe06574b7fae1b1c
Reviewed-on: https://chromium-review.googlesource.com/609406
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#493390}
[modify] https://crrev.com/f23317b2c1be4079096585efa94047c882b402c5/tools/perf/core/path_util.py

Cc: bpastene@chromium.org
Status: WontFix (was: Assigned)
*I think this flakiness goes away with the move to use single device swarming as this means Telemetry test no longer need to execute in parallel on Android bots ( issue 670879 ). Thanks bpastene@!
Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment