New issue
Advanced search Search tips

Issue 742420 link

Starred by 2 users
Status: Duplicate
Owner: ----
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:6728


Sign in to add a comment

gerrit shouldn't land patches that are empty except for the commit message (or mitigate dupe reverts some other way)

Project Member Reported by thakis@chromium.org, Jul 13 2017 
Affected Version:

What steps will reproduce the problem?
1. wez and I both created a revert of a Cl.
2. mine landed first
3. wez's (empty) cl still landed, https://chromium-review.googlesource.com/c/570518/

What is the expected output?

If more than 1 revert of a CL is cq'd, only one should land.

What do you see instead?


Please provide any additional information below.

Comment 1 by w...@chromium.org, Jul 13 2017 

This is made worse by the fact that the default setting in the Reland CL creation dialog is to TBR and CQ the reland - so in the case Nico and I saw, both of our CLs instantly landed on the tree!

Comment 2 by logan@google.com, Jul 13 2017

Components: -PolyGerrit
Labels: Proj-Gerrit-Migration
Sending over to chrome-infra for triage.

Comment 3 by logan@google.com, Jul 13 2017

Project: chromium
Moved issue gerrit:6728 to now be  issue chromium:742420 .

Comment 4 by aga...@chromium.org, Jul 13 2017

Components:
Mergedinto: 735839
Status: Duplicate (was: New)
►

Sign in to add a comment