New issue
Advanced search Search tips

Issue 742419 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Jul 2017
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router] Change volume while the volume slider is being dragged in WebUI route controller

Project Member Reported by taku...@chromium.org, Jul 13 2017 
The volume should change while the slider knob is being dragged, which was the behavior in the <extensionview> controller.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6a16073fd8b433d6f3cea80dfdccf1bbe6813b4

commit f6a16073fd8b433d6f3cea80dfdccf1bbe6813b4
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri Jul 14 23:55:49 2017

[Media Router] Update volume while dragging slider in WebUI route controller

Currently volume change requests are sent only when the user clicks and releases
the click. This CL makes it send requests even while the user is dragging the
slider knob, to match the behavior of the extensionview controller.

Bug:  742419 
Change-Id: I17e7d53fcf801e1cf720de4789f7b36aaf6dd6f8
Reviewed-on: https://chromium-review.googlesource.com/562836
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486948}
[modify] https://crrev.com/f6a16073fd8b433d6f3cea80dfdccf1bbe6813b4/chrome/browser/resources/media_router/elements/route_controls/route_controls.html
[modify] https://crrev.com/f6a16073fd8b433d6f3cea80dfdccf1bbe6813b4/chrome/browser/resources/media_router/elements/route_controls/route_controls.js

Comment 2 by taku...@chromium.org, Jul 17 2017

Status: Fixed (was: Started)
►

Sign in to add a comment