New issue
Advanced search Search tips

Issue 742416 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 716231



Sign in to add a comment

Input type buttons incorrectly rendered on Retina Mac if enable-use-zoom-for-dsf is enabled

Project Member Reported by shrike@chromium.org, Jul 13 2017

Issue description

Chrome Version: 61.0.3156.0
OS: macOS 10.12

What steps will reproduce the problem?
(1) Open a page with <input type="button">s

What is the expected result?
The buttons should resemble Mac platform buttons (light, rounded corners)

What happens instead?
The buttons are dark, with square corners

 
constant_animation.html
1.2 KB View Download
Actual.png
12.6 KB View Download
Expected.png
12.7 KB View Download
Labels: Needs-Feedback
NextAction: 2017-07-31
This works correctly in Chrome 61.0.3159.0 for me on MacOS 10.12.5

shrike@ can you test again in the latest canary?
Cc: tkent@chromium.org
Components: -Blink Blink>Forms
Sounds like a duplicate of 740409

tkent@ it is odd that these bugs are now being reported more frequently. Did something change in the zooming?

Comment 3 by shrike@chromium.org, Jul 17 2017

It appears to be related to #enable-use-zoom-for-dsf . When I disable that, the buttons are rendered as expected.

Comment 4 by tkent@chromium.org, Jul 17 2017

Retina devices might render fallback buttons even in 100% zoom if enable-use-zoom-for-dsf is enabled.

shrike@, did you see this issue on a Retina display device?

Comment 5 by shrike@chromium.org, Jul 17 2017

That's right - this is a Retina Mac.

Comment 6 by tkent@chromium.org, Jul 17 2017

Blocking: 716231
Labels: -Needs-Feedback
NextAction: ----
Status: Available (was: Untriaged)
Summary: Input type buttons incorrectly rendered on Retina Mac if enable-use-zoom-for-dsf is enabled (was: input type buttons incorrectly rendered on macOS)

Comment 7 by shrike@chromium.org, Jul 24 2017

Components: UI>HighDPI

Comment 8 by tkent@chromium.org, Jul 25 2017

Labels: -Pri-1 Pri-3
Decrease priority. I don't think enable-use-zoom-for-dsf is enabled on Mac by default soon.

The code fix is very simple.  We should add |&& style.EffectiveZoom() != 2.0f| to LayoutThemeMac::IsControlStyled().

Project Member

Comment 9 by sheriffbot@chromium.org, Jul 25

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)

Sign in to add a comment