New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 742388 link

Starred by 1 user
Status: Fixed
Owner:
█ zpeng@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 724110



Sign in to add a comment

Output what is actually packed in Chrome & WebView's (locale) resources

Project Member Reported by zpeng@chromium.org, Jul 13 2017 
At the moment, both Chrome and WebView uses resource whitelist to trim the locale paks. These generated whitelists are supposed to track what resources are actually used by Chrome & WebView. However, these whitelists do not accurately reflect what are actually packed into locale paks because WebView uses multiple resource whitelists other than compiler resource whitelist.

The plan is to modify repack_locales.py & data_pack.py and related build rules to output exact list of resource IDs, so that we can safely optimize our locale resources.

Comment 1 by zpeng@chromium.org, Jul 13 2017

Blocking: 724110
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/368afac85d2ca5e22efcbb2271c0d379b2fc22ab

commit 368afac85d2ca5e22efcbb2271c0d379b2fc22ab
Author: zpeng <zpeng@chromium.org>
Date: Mon Jul 17 18:47:45 2017

Reland of Deduplicate Monochrome locale .paks

Instead of using system webview's resource whitelist, now uses a
generated list of resource IDs that are actually packed into
Webview's locale paks. This fixes the missing strings issue.

Original issue:
https://codereview.chromium.org/2980773002/

TBR=agrieve@chromium.org,dpranke@chromium.org,thestig@chromium.org,sadrul@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days
ago.
BUG= 724110 ,  742388 

Review-Url: https://codereview.chromium.org/2977993002
Cr-Commit-Position: refs/heads/master@{#487176}

[modify] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/chrome/android/BUILD.gn
[modify] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/chrome/chrome_paks.gni
[modify] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/chrome/common/descriptors_android.h
[modify] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/tools/grit/pak_util.py
[modify] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/tools/resources/OWNERS
[add] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/tools/resources/filter_resource_whitelist.py
[modify] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/ui/base/resource/resource_bundle.cc
[modify] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/ui/base/resource/resource_bundle.h
[modify] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/ui/base/resource/resource_bundle_android.cc
[modify] https://crrev.com/368afac85d2ca5e22efcbb2271c0d379b2fc22ab/ui/base/resource/resource_bundle_android.h

Comment 3 by zpeng@chromium.org, Jul 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment