New issue
Advanced search Search tips

Issue 742380 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-double-free in ogg_read_close

Project Member Reported by ClusterFuzz, Jul 13 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5080550145785856

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-double-free
Crash Address: 0x608000002440
Crash State:
  ogg_read_close
  avformat_close_input
  media::FFmpegGlue::~FFmpegGlue
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=395675:395769

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5080550145785856


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 

Comment 1 by raymes@chromium.org, Jul 14 2017

Components: Internals>Media>FFmpeg
Labels: Pri-1
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)
libfuzzer was rolled in the regression range so not sure if that changed something to turn this up. 

dalecurtis: this looks like something in/around ffmpeg. Could you please help triage? Thanks!
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 14 2017

Labels: M-61
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 14 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: chcunningham@chromium.org jrumm...@chromium.org
+john,chris. 
Reported upstream since it repros with ffplay and --toolchain=clang-asan
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 26 2017

Labels: -Security_Impact-Head Security_Impact-Beta

Comment 7 by gov...@chromium.org, Jul 26 2017

URGENT - PTAL.
Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the M61 branch #3163 ASAP to have enough baking time in Beta before Stable promotion. Thank you!

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.

Labels: -OS-Linux OS-All
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1f8d825742c0f92f3bffb782677ea04a784bb63

commit d1f8d825742c0f92f3bffb782677ea04a784bb63
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Thu Jul 27 22:56:16 2017

Roll src/third_party/ffmpeg/ 97ebed679..a53b8db56 (1 commit)

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/97ebed67951a..a53b8db56039

$ git log 97ebed679..a53b8db56 --date=short --no-merges --format='%ad %ae %s'
2017-07-25 michael avformat/oggparsecelt: Do not re-allocate os->private

Created with:
  roll-dep src/third_party/ffmpeg

BUG= 742380 
TEST=none
TBR=chcunningham

Change-Id: Idf0a0346271678041af762a71c551cf293edbe92
Reviewed-on: https://chromium-review.googlesource.com/587996
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490047}
[modify] https://crrev.com/d1f8d825742c0f92f3bffb782677ea04a784bb63/DEPS

Will merge after clusterfuzz verifies.
Project Member

Comment 12 by ClusterFuzz, Jul 28 2017

ClusterFuzz has detected this issue as fixed in range 490022:490184.

Detailed report: https://clusterfuzz.com/testcase?key=5080550145785856

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-double-free
Crash Address: 0x608000002440
Crash State:
  ogg_read_close
  avformat_close_input
  media::FFmpegGlue::~FFmpegGlue
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=395675:395769
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=490022:490184

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5080550145785856


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Jul 28 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5080550145785856 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Jul 28 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Request-61
This is a merge request for a DEPS roll.
Project Member

Comment 16 by sheriffbot@chromium.org, Jul 28 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
+awhalley@ for M61 merge review
govind@ - looks good
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 branch 3163 based on comment #18. Please merge by 4:00 PM PT on Monday (07/31) so we can take it in for next week last Dev release. Thank you.
Are there any instructions for doing DEPS merges these days?
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/6b5b0c1d0e37a48d7b9037b124d76dded0d306fa

commit 6b5b0c1d0e37a48d7b9037b124d76dded0d306fa
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Mon Jul 31 19:26:14 2017

Labels: -ReleaseBlock-Stable
Seems like this is already merged to M61 at #21. Is there anything pending for M61?
Labels: -Merge-Approved-61 Merge-Merged
Nope, should be done.
Labels: -Merge-Merged merge-merged-3163
Thank you.
Project Member

Comment 26 by sheriffbot@chromium.org, Nov 3 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment