New issue
Advanced search Search tips

Issue 742373 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Text selection with Surface Pen not working

Reported by jotd...@gmail.com, Jul 13 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce the problem:
1. Select something on a webpage using a Surface Pen. For example, try to select a portion of the description under a Google search.
2. The icon for the cursor changes to a selection icon (looks like an "I")
2. No text can be selected.

What is the expected behavior?
The text should be selected when I press the pen against the screen and drag to emulate a mouse click and drag

What went wrong?
No text can be selected. When I move the pen over the text, the icon of the mouse input does change to a selection (similar to when I move over a link, it changes to a hand) the same way as with a mouse. But when I press the pen against the touchscreen to start the selection process, nothing happens.

Did this work before? Yes 58.0.3029.96

Chrome version: 59.0.3071.115  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 26.0 r0

The same problem is on Chrome Beta, Dev and Canary as of July 13 2017.
 
Labels: Needs-Triage-M61
Labels: TE-NeedsTriageFromMTV
Requesting MTV team for the triaging of the issue as we don't have surface pen here with India team.

Thanks!!
Components: -UI Blink>Input
Owner: lanwei@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1273cdee4d3b09bd7a425918ff16a48d5b47619d

commit 1273cdee4d3b09bd7a425918ff16a48d5b47619d
Author: lanwei <lanwei@chromium.org>
Date: Tue Jul 18 21:49:02 2017

Allow text selection on stylus input devices 

When we disabled the drag and drop on stylus input devices, we also
disabled the text selections. We should allow text selection on stylus
input devices, so users can copy and paste. 

Bug:742373

Change-Id: I9ea34111f5caef494c6c973a15ee15401b33c603
Reviewed-on: https://chromium-review.googlesource.com/574654
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487616}
[modify] https://crrev.com/1273cdee4d3b09bd7a425918ff16a48d5b47619d/third_party/WebKit/Source/core/input/MouseEventManager.cpp

Comment 5 by lanwei@chromium.org, Jul 20 2017

Labels: Merge-Request-60
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 20 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: We are only 4 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
This change meets the bar and is approved for M60 (build 3112)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 20 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/705d12ad12abd48c886a03ada74fc99244e10bfd

commit 705d12ad12abd48c886a03ada74fc99244e10bfd
Author: lanwei <lanwei@chromium.org>
Date: Thu Jul 20 20:44:25 2017

Allow text selection on stylus input devices

When we disabled the drag and drop on stylus input devices, we also
disabled the text selections. We should allow text selection on stylus
input devices, so users can copy and paste.

Bug:742373

TBR=lanwei@chromium.org

(cherry picked from commit 1273cdee4d3b09bd7a425918ff16a48d5b47619d)

Change-Id: I9ea34111f5caef494c6c973a15ee15401b33c603
Reviewed-on: https://chromium-review.googlesource.com/574654
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#487616}
Reviewed-on: https://chromium-review.googlesource.com/580402
Reviewed-by: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#658}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/705d12ad12abd48c886a03ada74fc99244e10bfd/third_party/WebKit/Source/core/input/MouseEventManager.cpp

Comment 9 by lanwei@chromium.org, Jul 26 2017

Status: Fixed (was: Assigned)

Sign in to add a comment