New issue
Advanced search Search tips

Issue 742360 link

Starred by 4 users

Issue metadata

Status: Duplicate
Merged: issue 289572
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

[canvas 2d] Implement the version of setTransform that takes a DOMMatrixInit dictionary

Project Member Reported by junov@chromium.org, Jul 13 2017

Issue description

Implement the version of setTransform that takes a DOMMatrixInit dictionary

Note: The row and column of DOMMatrix corresponding to the z-coordinate need to be simply discarded by setTransform(). This is about to be clarified in the spec: https://github.com/whatwg/html/issues/2826

 

Comment 1 by fs...@chromium.org, Sep 20 2017

Status: Started (was: Assigned)

Comment 2 by fs...@chromium.org, May 9 2018

Mergedinto: 289572
Status: Duplicate (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9347a40943840072196586f5a9e0839ba99375c1

commit 9347a40943840072196586f5a9e0839ba99375c1
Author: Fernando Serboncini <fserb@chromium.org>
Date: Tue May 15 18:26:46 2018

Adds getTransform/setTransform using DOMMatrix

Bug:  742360 
Change-Id: I49c21ea926e8c228986dc041108ca7b9449966c5
Reviewed-on: https://chromium-review.googlesource.com/676088
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558783}
[modify] https://crrev.com/9347a40943840072196586f5a9e0839ba99375c1/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[delete] https://crrev.com/2953d9b0d1d51ce57ddd6d7e055aec77a602849c/third_party/WebKit/LayoutTests/external/wpt/2dcontext/conformance-requirements/2d.voidreturn-expected.txt
[delete] https://crrev.com/2953d9b0d1d51ce57ddd6d7e055aec77a602849c/third_party/WebKit/LayoutTests/external/wpt/2dcontext/transformations/2d.transformation.setTransform.multiple-expected.txt
[modify] https://crrev.com/9347a40943840072196586f5a9e0839ba99375c1/third_party/WebKit/LayoutTests/external/wpt/css/geometry/DOMMatrix2DInit-validate-fixup-expected.txt
[modify] https://crrev.com/9347a40943840072196586f5a9e0839ba99375c1/third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces.https-expected.txt
[modify] https://crrev.com/9347a40943840072196586f5a9e0839ba99375c1/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9347a40943840072196586f5a9e0839ba99375c1/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9347a40943840072196586f5a9e0839ba99375c1/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/9347a40943840072196586f5a9e0839ba99375c1/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
[modify] https://crrev.com/9347a40943840072196586f5a9e0839ba99375c1/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.idl

Sign in to add a comment