New issue
Advanced search Search tips

Issue 742351 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

smoothness.desktop_tough_pinch_zoom_cases failing on mac

Project Member Reported by rnep...@chromium.org, Jul 13 2017

Issue description

CCing current perfbot sheriff. 

https://build.chromium.org/p/chromium.perf/builders/Mac%2010.11%20Perf/builds/905

ksadmin cannot access the ticket store:<KSUpdateError:0x10040c480
	domain="com.google.UpdateEngine.CoreErrorDomain"
	code=1051
	userInfo={
		function = "-[KSProductKeyedStore(ProtectedMethods) errorForStoreError:productID:message:timeoutMessage:]";
		date = 2017-07-12 09:11:10 +0000;
		productids = {(
			"com.google.Chrome"
		)};
		filename = "KSProductKeyedStore.m";
		line = 91;
		NSFilePath = "/Library/Google/GoogleSoftwareUpdate/TicketStore/Keystone.ticketstore";
		NSUnderlyingError = <KSError:0x100409e60
			domain="com.google.UpdateEngine.CommonErrorDomain"
			code=501
			userInfo={
				date = 2017-07-12 09:11:10 +0000;
				line = 372;
				filename = "KSKeyedPersistentStore.m";
				function = "-[KSKeyedPersistentStore(PrivateMethods) validateStorePath]";
				NSFilePath = "/Library/Google/GoogleSoftwareUpdate/TicketStore";
				NSLocalizedDescription = "KSKeyedPersistentStore store directory does not exist.";
			}
		>;
		NSLocalizedDescription = "KSPersistentTicketStore failed to load tickets.";
	}
>
2017-07-12 02:11:10.887 Google Chrome[7618:87736] -[SyntheticPinchEvent phase]: unrecognized selector sent to instance 0x7fde5bc69870
2017-07-12 02:11:10.890 Google Chrome[7618:87736] An uncaught exception was raised
2017-07-12 02:11:10.890 Google Chrome[7618:87736] -[SyntheticPinchEvent phase]: unrecognized selector sent to instance 0x7fde5bc69870
2017-07-12 02:11:10.890 Google Chrome[7618:87736] (
	0   CoreFoundation                      0x00007fff97fd1452 __exceptionPreprocess + 178
	1   Google Chrome Framework             0x000000011092ed7b ChromeMain + 24396139
	2   libobjc.A.dylib                     0x00007fff87b5373c objc_exception_throw + 48
	3   CoreFoundation                      0x00007fff9803b10d -[NSObject(NSObject) doesNotRecognizeSelector:] + 205
	4   CoreFoundation                      0x00007fff97f414d1 ___forwarding___ + 1009
	5   CoreFoundation                      0x00007fff97f41058 _CF_forwarding_prep_0 + 120
	6   Google Chrome Framework             0x000000010faa6ad3 ChromeMain + 9158339
	7   Google Chrome Framework             0x000000010fa2b3c9 ChromeMain + 8652729
	8   Google Chrome Framework             0x000000010fa2d9ab ChromeMain + 8662427
	9   Google Chrome Framework             0x000000010fa2d81a ChromeMain + 8662026
	10  Google Chrome Framework             0x000000010fa298fc ChromeMain + 8645868
	11  Google Chrome Framework             0x000000010fa2ab4b ChromeMain + 8650555
	12  Google Chrome Framework             0x0000000110d1ca77 ChromeMain + 28515943
	13  Google Chrome Framework             0x0000000110c9cd62 ChromeMain + 27992402
	14  Google Chrome Framework             0x0000000110cc2edb ChromeMain + 28148427
	15  Google Chrome Framework             0x0000000110cc32c5 ChromeMain + 28149429
	16  Google Chrome Framework             0x0000000110cc37c2 ChromeMain + 28150706
	17  Google Chrome Framework             0x0000000110cc6a23 ChromeMain + 28163603
	18  Google Chrome Framework             0x0000000110cb6a7a ChromeMain + 28098154
	19  Google Chrome Framework             0x0000000110cc632f ChromeMain + 28161823
	20  CoreFoundation                      0x00007fff97f667e1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
	21  CoreFoundation                      0x00007fff97f45f1c __CFRunLoopDoSources0 + 556
	22  CoreFoundation                      0x00007fff97f4543f __CFRunLoopRun + 927
	23  CoreFoundation                      0x00007fff97f44e38 CFRunLoopRunSpecific + 296
	24  HIToolbox                           0x00007fff9509f935 RunCurrentEventLoopInMode + 235
	25  HIToolbox                           0x00007fff9509f76f ReceiveNextEventCommon + 432
	26  HIToolbox                           0x00007fff9509f5af _BlockUntilNextEventMatchingListInModeWithFilter + 71
	27  AppKit                              0x00007fff8b298df6 _DPSNextEvent + 1067
	28  AppKit                              0x00007fff8b298226 -[NSApplication _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 454
	29  Google Chrome Framework             0x00000001108add00 ChromeMain + 23867632
	30  Google Chrome Framework             0x0000000110cb6a7a ChromeMain + 28098154
	31  Google Chrome Framework             0x00000001108adc44 ChromeMain + 23867444
	32  AppKit                              0x00007fff8b28cd80 -[NSApplication run] + 682
	33  Google Chrome Framework             0x0000000110cc723e ChromeMain + 28165678
	34  Google Chrome Framework             0x0000000110cc5c3c ChromeMain + 28160044
	35  Google Chrome Framework             0x0000000110ce87b3 ChromeMain + 28302243
	36  Google Chrome Framework             0x00000001108b3b65 ChromeMain + 23891797
	37  Google Chrome Framework             0x000000010f7d29c4 ChromeMain + 6192564
	38  Google Chrome Framework             0x000000010f7d5082 ChromeMain + 6202482
	39  Google Chrome Framework             0x000000010f7cec7c ChromeMain + 6176876
	40  Google Chrome Framework             0x000000011086a240 ChromeMain + 23590448
	41  Google Chrome Framework             0x00000001121addc4 ChromeMain + 50082228
	42  Google Chrome Framework             0x0000000110869824 ChromeMain + 23587860
	43  Google Chrome Framework             0x000000010f1eacb8 ChromeMain + 168
	44  Google Chrome                       0x000000010ef82dd4 main + 404
	45  libdyld.dylib                       0x00007fff8eb555ad start + 1
	46  ???                                 0x0000000000000019 0x0 + 25
)
INFO:root:*********** END OF BROWSER STANDARD OUTPUT ************
INFO:root:********************* BROWSER LOG *********************
INFO:root:No log file
INFO:root:***************** END OF BROWSER LOG ******************
Traceback (most recent call last):
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 102, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 314, in RunStory
    self._current_page.Run(self)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/__init__.py", line 112, in Run
    self.RunPageInteractions(action_runner)
  File "/b/s/w/ir/tools/perf/page_sets/tough_pinch_zoom_cases.py", line 35, in RunPageInteractions
    self.RunPinchGesture(action_runner, scale_factor=current_scale_factor)
  File "/b/s/w/ir/tools/perf/page_sets/tough_pinch_zoom_cases.py", line 29, in RunPinchGesture
    speed_in_pixels_per_second=speed_in_pixels_per_second)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 365, in PinchPage
    speed_in_pixels_per_second=speed_in_pixels_per_second))
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 56, in _RunAction
    action.RunAction(self._tab)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/pinch.py", line 74, in RunAction
    tab.WaitForJavaScriptCondition('window.__pinchActionDone', timeout=60)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 191, in WaitForJavaScriptCondition
    return self._inspector_backend.WaitForJavaScriptCondition(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 274, in WaitForJavaScriptCondition
    return py_utils.WaitFor(IsJavaScriptExpressionTrue, timeout)
  File "/b/s/w/ir/third_party/catapult/common/py_utils/py_utils/__init__.py", line 136, in WaitFor
    res = condition()
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 271, in IsJavaScriptExpressionTrue
    return self._EvaluateJavaScript(condition, context_id, timeout)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 39, in inner
    inspector_backend._ConvertExceptionFromInspectorWebsocket(e)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 36, in inner
    return func(inspector_backend, *args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 501, in _EvaluateJavaScript
    return self._runtime.Evaluate(expression, context_id, timeout)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 45, in Evaluate
    res = self._inspector_websocket.SyncRequest(request, timeout)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 110, in SyncRequest
    res = self._Receive(timeout)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 149, in _Receive
    data = self._socket.recv()
  File "/b/s/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 293, in recv
    opcode, data = self.recv_data()
  File "/b/s/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 310, in recv_data
    opcode, frame = self.recv_data_frame(control_frame)
  File "/b/s/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 323, in recv_data_frame
    frame = self.recv_frame()
  File "/b/s/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 357, in recv_frame
    return self.frame_buffer.recv_frame()
  File "/b/s/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_abnf.py", line 336, in recv_frame
    self.recv_header()
  File "/b/s/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_abnf.py", line 286, in recv_header
    header = self.recv_strict(2)
  File "/b/s/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_abnf.py", line 371, in recv_strict
    bytes_ = self.recv(min(16384, shortage))
  File "/b/s/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 427, in _recv
    return recv(self.sock, bufsize)
  File "/b/s/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_socket.py", line 93, in recv
    "Connection is already closed.")
DevtoolsTargetCrashException: <unprintable DevtoolsTargetCrashException object>
INFO:root:Devtools client not yet ready: [Errno 61] Connection refused
INFO:root:Try printing formatted exception: None None None
Exception raised when cleaning story run: 
Traceback (most recent call last):
  _RunStoryAndProcessErrorIfNeeded at /b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:129
    test.DidRunPage(state.platform)
  traced_function at /b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:75
    return func(*args, **kwargs)
  DidRunPage at /b/s/w/ir/tools/perf/measurements/smoothness.py:65
    self._tbm.DidRunStory(platform, self._results)
  DidRunStory at /b/s/w/ir/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement.py:309
    trace_result = platform.tracing_controller.StopTracing()
  StopTracing at /b/s/w/ir/third_party/catapult/telemetry/telemetry/core/tracing_controller.py:47
    return self._tracing_controller_backend.StopTracing()
  StopTracing at /b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:109
    self._IssueClockSyncMarker()
  _IssueClockSyncMarker at /b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:213
    self._RecordIssuerClockSyncMarker)
  RecordClockSyncMarker at /b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:177
    raise ChromeClockSyncError('Cannot issue clock sync. No devtools clients')
ChromeClockSyncError: Cannot issue clock sync. No devtools clients
 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jul 13 2017

Cc: erikc...@chromium.org
Owner: erikc...@chromium.org

=== Auto-CCing suspected CL author erikchen@chromium.org ===

Hi erikchen@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : Erik Chen
  Commit : 71535232c5bfac6324fd9ef74d132d647bfff24d
  Date   : Wed Jul 12 01:59:13 2017
  Subject: Fix pinch-to-zoom when linking against the 10.11 SDK or newer.

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : smoothness.desktop_tough_pinch_zoom_cases
  Metric       : frame_times/frame_times

Revision             Exit Code      N
chromium@485726      0 +- N/A       3      good
chromium@485762      0 +- N/A       3      good
chromium@485780      0 +- N/A       3      good
chromium@485789      0 +- N/A       3      good
chromium@485790      0 +- N/A       3      good
chromium@485791      1 +- N/A       3      bad       <--
chromium@485792      1 +- N/A       3      bad
chromium@485794      1 +- N/A       3      bad
chromium@485798      1 +- N/A       3      bad
chromium@485870      1 +- N/A       3      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests smoothness.desktop_tough_pinch_zoom_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8974176580672226928


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2c89114be7dbb8f239677d433f096fbceab6673

commit f2c89114be7dbb8f239677d433f096fbceab6673
Author: erikchen <erikchen@chromium.org>
Date: Fri Jul 14 01:02:56 2017

Fix synthetic pinch events for macOS.

A recent change to pinch event handling on macOS
(https://chromium-review.googlesource.com/567241) started checking for the
"phase" property. That was not defined for SyntheticPinchEvent.

Bug:  669240 ,  742351 
Change-Id: I304f2d0aac8302521711101e62ec69f6fcf2dadc
Reviewed-on: https://chromium-review.googlesource.com/571301
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486571}
[modify] https://crrev.com/f2c89114be7dbb8f239677d433f096fbceab6673/content/browser/renderer_host/input/synthetic_gesture_target_mac.mm

Status: Fixed (was: Untriaged)
Confirmed fixed.

Sign in to add a comment