New issue
Advanced search Search tips

Issue 742337 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Many ExtraDataContainer classes in third_party/WebKit/Source/platform/exported

Project Member Reported by brat...@opera.com, Jul 13 2017

Issue description

There are five different classes in third_party/WebKit/Source/platform/exported named ExtraDataContainer. They are only used as local internal classes so they don't normally collide in the compiler, but they do so in jumbo builds.

I plan to renamed them so that they have unique named. Since they are not exported outside the translation unit there will be no functional change.
 

Comment 1 by junov@chromium.org, Jul 13 2017

Components: -Blink Blink>Internals
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13d3f331a3a2be05c380738f9e62bc3945755178

commit 13d3f331a3a2be05c380738f9e62bc3945755178
Author: Daniel Bratell <bratell@opera.com>
Date: Thu Jul 13 21:30:47 2017

Rename 5*ExtraDataContainer to SomethingExtraDataContainer

There are five different classes in
third_party/WebKit/Source/platform/exported named ExtraDataContainer.
They are only used as local internal classes so they don't normally
collide in the compiler, but they do so in jumbo builds.

This patch renames them so that the names are more unique.

Bug:  742337 
Change-Id: Iad42e0d29f600fabd6ea9081687a7107d3043282
Reviewed-on: https://chromium-review.googlesource.com/570052
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: bratell at Opera <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#486481}
[modify] https://crrev.com/13d3f331a3a2be05c380738f9e62bc3945755178/third_party/WebKit/Source/platform/exported/WebMediaStream.cpp
[modify] https://crrev.com/13d3f331a3a2be05c380738f9e62bc3945755178/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
[modify] https://crrev.com/13d3f331a3a2be05c380738f9e62bc3945755178/third_party/WebKit/Source/platform/exported/WebPrerender.cpp
[modify] https://crrev.com/13d3f331a3a2be05c380738f9e62bc3945755178/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/13d3f331a3a2be05c380738f9e62bc3945755178/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

Comment 3 by brat...@opera.com, Jul 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment