[iOS] Issue with impression histograms in bookrmarks |
|||
Issue descriptionhttps://bugs.chromium.org/p/chromium/issues/detail?id=709286#c32 Interestingly, the behavior is different for MobileSignInPromo.BookmarkManager.* histograms. For those, it seems like every time the promo is shown, it counts as a new impression. So copying the above scenarios: 1) Open Bookmark Manager -- see sign-in promo 2) Click "Continue as..." 3) Click "UNDO" on the confirmation screen 4) Close Bookmark Manager --> an entry in bucket "1" for .ImpressionsTilSigninButtons and in bucket "1" for .ImpressionsTilDimiss 1) Open Bookmark Manager -- see sign-in promo 2) Click "Continue as..." 3) Click "UNDO" on the confirmation screen 4) Click "Continue as..." 5) Click "UNDO" on the confirmation screen 6) Close Bookmark Manager --> an entry in buckets "1" and "2" for .ImpressionsTilSigninButtons and an entry in bucket "3" for .ImpressionsTilDismiss I would expect in the first scenario a single entry in bucket "1" for .ImpressionsTilSigninButtons and in the second scenario two entries in bucket "1" for .ImpressionsTilSigninButtons.
,
Jul 13 2017
,
Jul 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f3d117be0d774445069db2c454fa9fbe8082780 commit 5f3d117be0d774445069db2c454fa9fbe8082780 Author: Jérôme Lebel <jlebel@chromium.org> Date: Mon Jul 17 11:50:47 2017 Fixing histograms bookmarks Issue: The impression count is sent to the dismiss histogram even if the sign-in promo has been previously used. Since the interaction sign-in controller starts the sign-in as soon as the "Continue as..." is clicked, then the sign-in mediator from BookmarkCollectionView is deallocated. The issue is if the sign-in is canceled, then the new created mediator doesn't know that the sign-in promo has just been used. BookmarkCollectionView should keep the sign-in promo view as long as the sign-in started by the mediator is in progress. Therefore, the mediator will report the right histogram when it will be destroyed. Bug: 742335 Change-Id: I85a89c647a89691007af4942ebd89aef15b28231 Reviewed-on: https://chromium-review.googlesource.com/567081 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#487045} [modify] https://crrev.com/5f3d117be0d774445069db2c454fa9fbe8082780/ios/chrome/browser/ui/authentication/signin_promo_view_consumer.h [modify] https://crrev.com/5f3d117be0d774445069db2c454fa9fbe8082780/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h [modify] https://crrev.com/5f3d117be0d774445069db2c454fa9fbe8082780/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.mm [modify] https://crrev.com/5f3d117be0d774445069db2c454fa9fbe8082780/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.h [modify] https://crrev.com/5f3d117be0d774445069db2c454fa9fbe8082780/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm
,
Jul 17 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jlebel@chromium.org
, Jul 13 2017