New issue
Advanced search Search tips

Issue 742332 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 709286



Sign in to add a comment

[iOS] needs Signin_ImpressionNoAccount_From/Signin_ImpressionWithAccount_From

Project Member Reported by jlebel@chromium.org, Jul 13 2017

Issue description

Needs implementation for Signin_ImpressionNoAccount_From/Signin_ImpressionWithAccount_From
 

Comment 1 by jlebel@chromium.org, Jul 13 2017

Blocking: 709286

Comment 2 by ew...@chromium.org, Jul 13 2017

Labels: -Pri-3 M-61 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/780ed524823d11e245f40c2f68ebf03a0b2c3ee0

commit 780ed524823d11e245f40c2f68ebf03a0b2c3ee0
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Wed Jul 19 07:34:46 2017

Record Signin_ImpressionWithAccount_From* and Signin_ImpressionWithNoAccount_From*

Adding user action metrics to record impression for the new sign-in promo
view when it is shown with a default account or without a default account.

Bug:  742332 
Change-Id: Ic095395f037790b4ff887d29fc7c2edeaffb304a
Reviewed-on: https://chromium-review.googlesource.com/576091
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487781}
[modify] https://crrev.com/780ed524823d11e245f40c2f68ebf03a0b2c3ee0/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.mm
[modify] https://crrev.com/780ed524823d11e245f40c2f68ebf03a0b2c3ee0/tools/metrics/actions/actions.xml

Comment 4 by jlebel@chromium.org, Jul 19 2017

Status: Fixed (was: Assigned)

Sign in to add a comment