[iOS] "other devices" sign-in access counted as "recent tabs" |
|||
Issue descriptionI've done a mistake. "Other devices" is counted as "Recent tabs" for the sign-in histograms. I've noticed there is ACCESS_POINT_DEVICES_PAGE: https://cs.chromium.org/chromium/src/tools/metrics/actions/actions.xml?q=ACCESS_POINT_DEVICES_PAGE&sq=package:chromium&l=15825 Is it for "Other devices"? Should I use that one for "Other devices", or should I create a new one?
,
Jul 13 2017
Also there is no: Signin_Signin_From* Signin_SigninWithDefault_From* Signin_SigninNotDefault_From* Signin_SigninNewAccount_From* for "Other devices".
,
Jul 13 2017
The are all counted as "Recent tabs".
,
Jul 13 2017
I found that I should use ACCESS_POINT_TAB_SWITCHER.
,
Jul 13 2017
If possible, let's try to get this fix into M61.
,
Jul 13 2017
The patch is done, waiting for the review.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f86a260b9d02c7cecd1848801cab6de81c3d5b9c commit f86a260b9d02c7cecd1848801cab6de81c3d5b9c Author: Jérôme Lebel <jlebel@chromium.org> Date: Fri Jul 14 23:15:47 2017 Fixing tab switcher access user action metrics The sign-in promo view in the tab switcher should use ACCESS_POINT_TAB_SWITCHER access point (instead of ACCESS_POINT_RECENT_TABS. Also adding histograms for the tab switcher (instead of using the one for recent tabs). Bug introduced with crrev.com/2885943002 Histograms added with crrev.com/2871753002 Bug: 742331 Change-Id: I9ac3864ba692081115df7f368417a82673bf1b62 Reviewed-on: https://chromium-review.googlesource.com/570958 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#486927} [modify] https://crrev.com/f86a260b9d02c7cecd1848801cab6de81c3d5b9c/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.mm [modify] https://crrev.com/f86a260b9d02c7cecd1848801cab6de81c3d5b9c/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm [modify] https://crrev.com/f86a260b9d02c7cecd1848801cab6de81c3d5b9c/tools/metrics/actions/actions.xml
,
Jul 14 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jlebel@chromium.org
, Jul 13 2017