New issue
Advanced search Search tips

Issue 742316 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 727596



Sign in to add a comment

Remove wrong SetFetchCredentialsMode() calls

Project Member Reported by tyoshino@chromium.org, Jul 13 2017

Issue description

https://chromium.googlesource.com/chromium/src.git/+/2e231cf052ca5e68e22baf0008ac9e5e29121707 added bunch of SetFetchCredentialsMode() calls in test (and helper) files just not to change anything, but many of them are just wrong.

Some of them are now being removed by https://chromium-review.googlesource.com/c/567690.

Check the rest carefully to remove wrong ones, otherwise incorrect failures/success caused by the wrong call might hide actual test break in the future.
 

Comment 1 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 2 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Components: -Internals>Services>Network Blink>Loader
Owner: toyoshim@chromium.org
Tentatively assigning to toyoshim@ as he's working on a big CORS refactoring.
Owner: ----
Status: Available (was: Assigned)
Undoing considering his bandwidth and severity.
Cc: toyoshim@chromium.org
Labels: Hotlist-GoodFirstBug OOR-CORS
:)

Let me set OOR-CORS too though this is not actually directly related to the OOR-CORS, but can be in my radar.

Sign in to add a comment