New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 742312 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Jul 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Small grey line below the NTP omnibox when pinned to top

Project Member Reported by gambard@chromium.org, Jul 13 2017 
When the fake omnibox displayed on the NTP is pinned to top, there is a 1px grey line displayed just below it.
This line is not visible on the real omnibox. When the omnibox is focused, the removal of this line is visible.
Screenshot 1.png
29.8 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17de6f0d76de72269674be12cb59e86f3bf9800c

commit 17de6f0d76de72269674be12cb59e86f3bf9800c
Author: gambard <gambard@chromium.org>
Date: Thu Jul 13 15:31:28 2017

Change fake omnibox constraints and image

The fake omnibox displayed on the NTP is slightly missaligned with the
real omnibox.
This CL makes then aligned by increasing the height of the fake omnibox
image by one pixel and moving the shadow below it by one pixel.
The transparent pixels around the image have been removed.

Bug:  742312 
Change-Id: I99406a9d012a06f500b5f20675de0b75cd440a1a
Reviewed-on: https://chromium-review.googlesource.com/569968
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486385}
[modify] https://crrev.com/17de6f0d76de72269674be12cb59e86f3bf9800c/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[modify] https://crrev.com/17de6f0d76de72269674be12cb59e86f3bf9800c/ios/chrome/browser/ui/ntp/resources/ntp_google_search_box.imageset/ntp_google_search_box@2x.png
[modify] https://crrev.com/17de6f0d76de72269674be12cb59e86f3bf9800c/ios/chrome/browser/ui/ntp/resources/ntp_google_search_box.imageset/ntp_google_search_box@3x.png

Comment 2 by gambard@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)

Comment 3 by subhashi...@chromium.org, Jul 18 2017

Status: Verified (was: Fixed)
Verified on:

App Version: 61.0.3159.0 canary
Devices: iPhone5S, iPhone 6 Plus
iOS Version: 9.3.5, 10.3.1

Issue is fixed. Grey line is not visible when fake omnibox displayed on NTP is pinned to top. Tested with portrait and landscape device orientations. Please see the screenshots attached.
FakeOmnibox_iPhone6plus.JPG
108 KB View Download
FakeOmnibox_iPhone5S.PNG
121 KB View Download
►

Sign in to add a comment