New issue
Advanced search Search tips

Issue 742302 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Make UserCloudPolicyStoreChromeOS use CachedPolicyKeyLoaderChromeOS

Project Member Reported by pmarko@chromium.org, Jul 13 2017

Issue description

CL:564609 introduces CachedPolicyKeyLoaderChromeOS which has been extracted from UserCloudPolicyStoreChromeOS.

Change UserCloudPolicyStoreChromeOS to actually use CachedPolicyKeyLoaderChromeOS.

 

Comment 1 by pmarko@chromium.org, Jul 13 2017

Labels: -Type-Bug Type-Task
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/221fd61a7840570e74eb9e8a71c48b6bf8000142

commit 221fd61a7840570e74eb9e8a71c48b6bf8000142
Author: Pavol Marko <pmarko@chromium.org>
Date: Thu Jul 27 14:07:42 2017

Use CachedPolicyKeyLoaderChromeOS from UserCloudPolicyStoreChromeOS

Use CachedPolicyKeyLoaderChromeOS to load the cached policy key
provided by session_manager in UserCloudPolicyStoreChromeOS.
CachedPolicyKeyLoaderChromeOS was originally introduced
for PreSigninPolicyFetcher with the longer term goal to be used from
UserCloudPolicyStoreChromeOS too.

BUG= 742302 
TEST=unit_tests --gtest_filter=UserCloudPolicyStoreChromeOSTest*

Change-Id: I4e386392e258b359b6632f17b97852f960f0781f
Reviewed-on: https://chromium-review.googlesource.com/581107
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489912}
[modify] https://crrev.com/221fd61a7840570e74eb9e8a71c48b6bf8000142/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc
[modify] https://crrev.com/221fd61a7840570e74eb9e8a71c48b6bf8000142/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h

Comment 3 by pmarko@chromium.org, Jul 27 2017

Status: Fixed (was: Assigned)
Regression testing should be enough here, this is fine if user policy is not broken.

Sign in to add a comment