New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742290 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
hobby only
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 739404



Sign in to add a comment

Periods (full-stops) in password settings snackbars on iOS

Project Member Reported by vabr@chromium.org, Jul 13 2017

Issue description

There are four snackbars for copy operations in the password detail view on iOS settings. These are for copying site, username, and two version of copying password (successful one and one failed because of failed reauthentication). All four are attached below in screenshots.

The three successful ones are one-sentence, the failed one has two sentences.

ainslie@ suggested the one-sentence ones could be without the period at the end of the sentence.

srahim@ -- I would appreciate your guidance on the messages shown in the attached screenshots.

(This was flagged as a non-launch-blocking issue. I am still marking this "blocking" the launch bug for now just for easier tracking.)
 
copy_site.png
209 KB View Download
copy_username.png
210 KB View Download
copy_password_auth_successful.png
210 KB View Download
copy_password_auth_failed.png
210 KB View Download

Comment 1 by srahim@chromium.org, Jul 18 2017

No periods for the single sentences. In addition, UX writing style would write these as:
Site address copied (I'd avoid 'URL')
Password copied
Username copied

For the 2 sentence toast, the punctuation is correct, but I would rewrite the text to be more user-friendly. "Can't sign in. Password not copied." or "Can't verify your identity. Password not copied." I'm not sure what "Authentication failed" means here. Isn't the user already signed in if they are able to access the password manager?

Comment 2 by vabr@chromium.org, Jul 19 2017

Status: Started (was: Assigned)
Thanks a lot for the guidance!

The single-sentence toasts are now clarified, I will implement the changes from #1.

For the two-sentence toast, I think "Can't verify your identity. Password not copied." is more appropriate than "Can't sign in. ..." The reauthentication is to verify that the user trying to view passwords is able to unlock the device, it does not serve the purpose of signing in to any account. I will therefore change the code to use "Can't verify your identity. Password not copied."
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/574f0bf33a61976d995c14e979d295f3bea8bb39

commit 574f0bf33a61976d995c14e979d295f3bea8bb39
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Jul 19 10:00:48 2017

Adjust strings in passwords settings on iOS

This CL adjusts strings used in the passwords detail view, based on the
following guidance from UX:
  *  https://crbug.com/740379#c9  Shortening "Delete Saved Password" to just "Delete"
  *  https://crbug.com/740384#c11  Identifying the federation URL with "Signed In With"
  *  https://crbug.com/742290#c1  Improving the copy toasts: URL -> address,
    simpler phrasing and no full-stops for one-sentence messages

Bug:  740379 , 740384 , 742290 
Change-Id: I1eec2a44fd5d2acd59166988431832e88f8737e6
Reviewed-on: https://chromium-review.googlesource.com/577528
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487810}
[modify] https://crrev.com/574f0bf33a61976d995c14e979d295f3bea8bb39/ios/chrome/app/strings/ios_strings.grd

Comment 4 by vabr@chromium.org, Jul 19 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Site address copied 
Password copied
Username copied
Verified on iOS 10.3.3, 11.0 on iPhone 6 +, iPhone 7+, iPad Pro 12'5 on build 62.0.3202.29 Beta.

Sign in to add a comment