New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742283 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Localized (component) update prompts truncated

Reported by norb...@rittel.de, Jul 13 2017

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 9693.1.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3144.0 Safari/537.36
Platform: 9693.1.0 (Official Build) dev-channel panther

Steps to reproduce the problem:
When a component like Flash Player has been updated in the background a Restart prompt appears in the System Tray.

What is the expected behavior?
It should be fully readable, perhaps by making the text scroll horizontally or wrap around.

What went wrong?
As shown in the enclosed screen shot of the German UI that prompt does not fit the provided space and becomes truncated.

Here the text "zu aktualisieren" ("to update") is cut off which is the most important information here.

Did this work before? N/A 

Chrome version: 61.0.3144.0  Channel: dev
OS Version: 9693.1.0
Flash Version: 26.0.0.126 

Having that text scroll would also increase the chance of immediate user reaction.
 
Screenshot 2017-07-13 at 12.19.39.png
88.8 KB View Download
Owner: tbuck...@chromium.org
Status: Assigned (was: Unconfirmed)
To tbuckley@ for Status tray FR.
Components: -UI UI>Shell>StatusArea
Status: Untriaged (was: Assigned)
Cc: tbuck...@chromium.org
Owner: tdander...@chromium.org
Status: Assigned (was: Untriaged)
@tdanderson would you be able to take a look at this? Seems like the row should be multi-line when needed.
Cc: -tbuck...@chromium.org tdander...@chromium.org zork@chromium.org fukino@chromium.org
Owner: tbuck...@chromium.org
I likely won't have a chance to look at this, so I am handing this back to you Tom. Perhaps zork@ or fukino@ may be able to help find an owner.
Cc: tbuck...@chromium.org
Owner: zork@chromium.org
@zork is someone on your team able to look into adding multi-line support to the update row? Other rows, eg supervised users, should already have multi-line.
Owner: sammiequon@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f38c9a754438b6111c91d87a910c288f472a49d4

commit f38c9a754438b6111c91d87a910c288f472a49d4
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Nov 02 18:35:37 2017

tray: Fix focus rectangle for tray_info_label.

See  bug 771102  for screenshots. The label covers some of the of the focus
rectangle. Changed to use box layout so the label does not take up more
space than it needs.

Fix two other small bugs.
1) Strings for updating flash cutoff in German. Add label multiline
for that label.
2) Tab focus going on power, even though it is not a button. Users using
tab require to tabs to go from the last highlighted region (time) to the
next (sign out).

Test: manual
Bug:  771102 ,  742283 ,  769240 
Change-Id: I9bc25be80166afcdff2664a457c1f775a8065456
Reviewed-on: https://chromium-review.googlesource.com/750066
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513560}
[modify] https://crrev.com/f38c9a754438b6111c91d87a910c288f472a49d4/ash/system/power/power_status_view.cc
[modify] https://crrev.com/f38c9a754438b6111c91d87a910c288f472a49d4/ash/system/tray/tray_info_label.cc
[modify] https://crrev.com/f38c9a754438b6111c91d87a910c288f472a49d4/ash/system/update/tray_update.cc

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 13 2017

Labels: merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac9b2b4eade6c978204662cf6c0e08b5129fabb8

commit ac9b2b4eade6c978204662cf6c0e08b5129fabb8
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Nov 13 22:13:18 2017

[merge to m63] tray: Fix focus rectangle for tray_info_label.

See  bug 771102  for screenshots. The label covers some of the of the focus
rectangle. Changed to use box layout so the label does not take up more
space than it needs.

Fix two other small bugs.
1) Strings for updating flash cutoff in German. Add label multiline
for that label.
2) Tab focus going on power, even though it is not a button. Users using
tab require to tabs to go from the last highlighted region (time) to the
next (sign out).

TBR=sammiequon@google.com

(cherry picked from commit f38c9a754438b6111c91d87a910c288f472a49d4)

TBR: stevenjb@chromium.org
Test: manual
Bug:  771102 ,  742283 ,  769240 
Change-Id: I9bc25be80166afcdff2664a457c1f775a8065456
Reviewed-on: https://chromium-review.googlesource.com/750066
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#513560}
Reviewed-on: https://chromium-review.googlesource.com/767113
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#472}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/ac9b2b4eade6c978204662cf6c0e08b5129fabb8/ash/system/power/power_status_view.cc
[modify] https://crrev.com/ac9b2b4eade6c978204662cf6c0e08b5129fabb8/ash/system/tray/tray_info_label.cc
[modify] https://crrev.com/ac9b2b4eade6c978204662cf6c0e08b5129fabb8/ash/system/update/tray_update.cc

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 11 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment