New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 742282 link

Starred by 1 user
Status: WontFix
Owner:
tommycli@chromium.org
Closed: Jul 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
tbuck...@chromium.org
█ msrchandra@chromium.org
dpa...@chromium.org
█ ranjitkan@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary 'Do not track' overlay gets closed after pressing 'Enter' key.

Reported by db...@etouch.net, Jul 13 2017 
Chrome Version: 61.0.3156.0 (Official Build)7a4241c698a71a5cc10ec6135060f4d99af2b96c-refs/heads/master@{#486205} (32/64-bit)
OS: Mac (10.12.3, 10.11.6, 10.12),Windows (7,8,8.1,10),Linux (14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://settings/privacy
(2) Click on toggle button of ‘Send a “Do not track” request with your browsing traffic such that overlay is seen.
(3) Then press Enter key and observe

Actual: Unnecessary overlay gets closed i.e. toggle button gets enabled even if focus is not on 'Confirm' button.

Expected: Do not track overlay should not closed after pressing Enter key.

This is a regression issue, broken in 'M-59', will soon update the other info:

Good Build: 59.0.3060.0
Bad Build: 59.0.3062.0

Note: Do not tack overlay does not close on second Enter.
Actual_Settings.mov
8.2 MB Download
Expected_Settings.mov
2.3 MB Download

Comment 1 by db...@etouch.net, Jul 13 2017

Labels: hasbisect
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/dfa79e7a178a8f106754232833b4bd4327f76193..0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b?pretty=fuller&n=100

Suspecting: r461585

Comment 2 by tommycli@chromium.org, Jul 27 2017

Cc: dpa...@chromium.org
dpapad: Is this accurate? I thought we in fact _did_ want to close the DNT dialog on Enter?

Comment 3 by tommycli@chromium.org, Jul 27 2017

Cc: steve...@chromium.org
+stevenjb in case he knows the desired behavior.

Comment 4 by dpa...@chromium.org, Jul 27 2017

Cc: tbuck...@chromium.org
+tbuckley: In most case we trigger the "action" button when the "enter" key is pressed. I don't know/remember if DNT dialog is a special case.

Comment 5 by tommycli@chromium.org, Jul 27 2017

Status: WontFix (was: Assigned)
It only works the first time in any case: 749860 which is a related bug.

IMO, it should operate as normal, as the DNT dialog is basically just a warning and the user can easily turn the setting back to how it was.

It's not like "Clear browsing data" or "Signout" where the consequences are more permanent. I'll mark this as Working As Intended speculatively, and let tbuckley@ object if I'm wrong here.
►

Sign in to add a comment