New issue
Advanced search Search tips

Issue 742262 link

Starred by 6 users
Status: Fixed
Owner:
vapier@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

nassh: 0.8.36.6 doesn't always show imported identities

Reported by matof...@gmail.com, Jul 13 2017 
Chrome Version       : 59.0.3071.91
URLs (if applicable) :

What steps will reproduce the problem?
(1) Import identity keys
(2) Close SSH window
(3) Reopen SSH window

What is the expected result?

Imported identity to be available and as in previous versions selected as default for all connections.


What happens instead?

It's not there. And there is no [default] identity either. After I import a key file identity shows up again but disappears again after closing/reopening window. The problem seems to be somewhat random - from time to time after opening new window the identity is there then it disappears again.


Please provide any additional information below. Attach a screenshot if
possible.

The problem is shown here: https://www.youtube.com/watch?v=MS-nav0SSU4

It worked fine up until the update to 0.8.36.6.

Comment 1 by d...@forkbox.net, Jul 14 2017 

As in the announcement thread, it seems that importing a random file will cause the list of saved keys to reappear and work. But when the identities seem gone, they really are gone in that I also can't actually connect to the server in question.

I can reproduce this by hitting ctrl+shift+n, then ctrl+w, and repeating -- sometimes the new window pops up with my saved identities available, sometimes it doesn't.

It seems that when the keys work, the form under "SSH relay server options" is significantly indented. When the keys don't work, that form is all the way to the left.

Comment 2 by vapier@chromium.org, Jul 14 2017

Labels: OS-All
Summary: nassh: 0.8.36.6 doesn't always show imported identities (was: SSH 0.8.36.6 won't show imported identities)
when it loads weird, can you open the javascript console (ctrl+shift+j) and see if there's any errors in there ?

Comment 3 by matof...@gmail.com, Jul 14 2017 

I've already tried it, and there was no difference between reloads with or without identities.

Comment 4 Deleted

Comment 5 Deleted

Comment 6 by eldrid...@gmail.com, Jul 18 2017 

I see this as well.
However it appears the "Default" identity is used regardless of the display.

Comment 7 by vapier@chromium.org, Jul 18 2017

Owner: vapier@chromium.org
Status: Started (was: Unconfirmed)
CL to fix is in flight and will be in 0.8.36.8+
  https://chromium-review.googlesource.com/576208
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/18c1cdbbab7b504b22610f044102107a04751e6f

commit 18c1cdbbab7b504b22610f044102107a04751e6f
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jul 19 18:19:05 2017

nassh: stop padding identity options

The label rework in commit 0425eccbd4546e71d51448e72e85e412b0223701
(nassh: rework label padding) incorrectly applied padding to the drop
down options in the identity box.  Revert part of that change so we
only pad the actual text labels on the left of the inputs.

BUG= chromium:742262 

Change-Id: I6523468f79298c5dff7dd0904e1e0aa7868de2ab
Reviewed-on: https://chromium-review.googlesource.com/576208
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/18c1cdbbab7b504b22610f044102107a04751e6f/nassh/html/nassh_connect_dialog.html

Comment 9 by vapier@chromium.org, Jul 19 2017

Status: Fixed (was: Started)
should be fixed with 0.8.36.8
►

Sign in to add a comment