Add unit tests for generation of Xcode project by gn |
||
Issue descriptionThe code to generate Xcode project by gn is getting quite big and there are no unit tests. This should be fixed and unit tests should be added.
,
Jul 13 2017
I'm happy to do this in my free time.
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1ff6ba517e5df483388550ebe07c3fe3c691413 commit b1ff6ba517e5df483388550ebe07c3fe3c691413 Author: Yuke Liao <liaoyuke@chromium.org> Date: Wed Jul 19 18:02:11 2017 [GN] Add unit tests for Xcode objects: exercise class instantiations. This CL adds unit test files for Xcode objects in tools/gn/xcode_object.h, and specifically exercises class instantiations and tests that it doesn't crash. Bug: 742258 Change-Id: I234b0e643e718edf09a011c390c70c1d5ed0743f Reviewed-on: https://chromium-review.googlesource.com/572702 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#487912} [modify] https://crrev.com/b1ff6ba517e5df483388550ebe07c3fe3c691413/tools/gn/BUILD.gn [add] https://crrev.com/b1ff6ba517e5df483388550ebe07c3fe3c691413/tools/gn/xcode_object_unittest.cc
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da4fc47d51d4aa4da88816fb33b255be01d95885 commit da4fc47d51d4aa4da88816fb33b255be01d95885 Author: Yuke Liao <liaoyuke@chromium.org> Date: Thu Aug 24 15:58:39 2017 [GN] Add a few more unit tests for Xcode objects. This CL adds unit test files for Xcode objects in tools/gn/xcode_object.h, and specifically tests the mapping between a object and its class enum type and the mapping between a classe type and its name as a string. Bug: 742258 Change-Id: Iab70bc2f3c0eedccd427e618d74f8077dcaee5c7 Reviewed-on: https://chromium-review.googlesource.com/630699 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#497064} [modify] https://crrev.com/da4fc47d51d4aa4da88816fb33b255be01d95885/tools/gn/xcode_object_unittest.cc
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c37f1fbd518e718132d5c3aae2298d951a06e90 commit 9c37f1fbd518e718132d5c3aae2298d951a06e90 Author: Yuke Liao <liaoyuke@chromium.org> Date: Mon Sep 11 23:40:11 2017 [GN] Add unit tests for the mapping between PBXObject and it's name. This CL adds unit tests to test the mapping between a PBXObject and its name as a string by calling Name(). Bug: 742258 Change-Id: I8a4b55af84d1270f1c3c8927e4f124ddff0532e9 Reviewed-on: https://chromium-review.googlesource.com/636360 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#501099} [modify] https://crrev.com/9c37f1fbd518e718132d5c3aae2298d951a06e90/tools/gn/xcode_object_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by lgrey@chromium.org
, Jul 13 2017