Two different Command classes in fetch unit tests causes jumbo collisions |
||
Issue descriptionThere is a DataConsumerHandleTestUtil::Command class and a BytesConsumerTestUtil::Command class in fetch unit tests. They are both imported into the global/blink namespace with "using" statements and in jumbo builds the classes collide.
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c72b68028a9adba323c7e7f8f7b7eac3ee7ee01 commit 3c72b68028a9adba323c7e7f8f7b7eac3ee7ee01 Author: Daniel Bratell <bratell@opera.com> Date: Thu Jul 13 11:31:42 2017 Make the fetch unit test Command class not collide. In jumbo builds the two Command classes in fetch unit_tests would collide since they are both imported into the same global/blink scope with "using" statements. This patch changed the "using" statements to give the classes different names. R=tyoshino@chromium.org Bug: 742239 Change-Id: I37a783755049ff36ebd63f6b432a0e07bce4a4db Reviewed-on: https://chromium-review.googlesource.com/570018 Commit-Queue: bratell at Opera <bratell@opera.com> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#486342} [modify] https://crrev.com/3c72b68028a9adba323c7e7f8f7b7eac3ee7ee01/third_party/WebKit/Source/modules/fetch/BlobBytesConsumerTest.cpp [modify] https://crrev.com/3c72b68028a9adba323c7e7f8f7b7eac3ee7ee01/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp [modify] https://crrev.com/3c72b68028a9adba323c7e7f8f7b7eac3ee7ee01/third_party/WebKit/Source/modules/fetch/BytesConsumerForDataConsumerHandleTest.cpp [modify] https://crrev.com/3c72b68028a9adba323c7e7f8f7b7eac3ee7ee01/third_party/WebKit/Source/modules/fetch/BytesConsumerTest.cpp [modify] https://crrev.com/3c72b68028a9adba323c7e7f8f7b7eac3ee7ee01/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
,
Jul 14 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by brat...@opera.com
, Jul 13 2017Labels: OS-All
Owner: brat...@opera.com
Status: Assigned (was: Unconfirmed)