New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 742235 link

Starred by 1 user
Status: Fixed
Owner:
█ hu...@opera.com
Email to this user bounced
Closed: Jul 2017
Cc:
yoichio@chromium.org
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

I-beam is shown even when user-select: none

Reported by hu...@opera.com, Jul 13 2017 
Chrome Version: 59.0.3071.115

What steps will reproduce the problem?
Hover text that has user-select: none.

What is the expected result?
Normal mouse pointer is shown.

What happens instead?
I-beam is shown.

Interop:
Works in Firefox 54.0.1 (-moz-user-select: none).

Repro:
<div style="background: yellow; user-select: none; -moz-user-select: none;">
this text is not selectable
</div>

<div style="background: green;">
this text is selectable
</div>

Comment 1 by hu...@opera.com, Jul 13 2017

Owner: hu...@opera.com
Status: Started (was: Available)
Started at https://chromium-review.googlesource.com/c/570246/ .
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a66627f0f0a681fcf3111a9bb0f01a8e0790186

commit 7a66627f0f0a681fcf3111a9bb0f01a8e0790186
Author: Hugo Holgersson <hugoh@opera.com>
Date: Tue Jul 25 18:01:57 2017

Do not show I-beam when hovering 'user-select: none'

All elements now have 'user-select: auto' as their default
value (not 'user-select: text').

Spec: https://drafts.csswg.org/css-ui-4/#propdef-user-select

This default value has no effect; elements are styled as usual.
This is important because Blink needs a "no change" default
to be able to find cases where 'user-select' should affect
mouse pointer styling.

BUG= 742235 
TEST=EventHandlerTest.ChildCanOverrideUserSelectText
     EventHandlerTest.HitOnUserSelectNoneDoesNotShowIBeam
     EventHandlerTest.ShadowChildCanOverrideUserSelectText

Above 3 tests failed before this patch.

Change-Id: I1ed0ad69daf6a1a1bd4b21623fcdb145ef596d88
Reviewed-on: https://chromium-review.googlesource.com/570246
Commit-Queue: Hugo Holgersson <hugoh@opera.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489363}
[add] https://crrev.com/7a66627f0f0a681fcf3111a9bb0f01a8e0790186/third_party/WebKit/LayoutTests/editing/selection/mouse/overidden_user_select_in_dom_tree.html
[add] https://crrev.com/7a66627f0f0a681fcf3111a9bb0f01a8e0790186/third_party/WebKit/LayoutTests/editing/selection/mouse/overriden_user_select_in_shadow_tree.html
[modify] https://crrev.com/7a66627f0f0a681fcf3111a9bb0f01a8e0790186/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/7a66627f0f0a681fcf3111a9bb0f01a8e0790186/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/7a66627f0f0a681fcf3111a9bb0f01a8e0790186/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/7a66627f0f0a681fcf3111a9bb0f01a8e0790186/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/7a66627f0f0a681fcf3111a9bb0f01a8e0790186/third_party/WebKit/Source/core/css/CSSValueIDMappings.h
[modify] https://crrev.com/7a66627f0f0a681fcf3111a9bb0f01a8e0790186/third_party/WebKit/Source/core/css/html.css
[modify] https://crrev.com/7a66627f0f0a681fcf3111a9bb0f01a8e0790186/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/7a66627f0f0a681fcf3111a9bb0f01a8e0790186/third_party/WebKit/Source/core/editing/EditingTestBase.h
[modify] https://crrev.com/7a66627f0f0a681fcf3111a9bb0f01a8e0790186/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/7a66627f0f0a681fcf3111a9bb0f01a8e0790186/third_party/WebKit/Source/core/input/EventHandlerTest.cpp

Comment 3 by hu...@opera.com, Jul 31 2017

Status: Fixed (was: Started)
►

Sign in to add a comment