New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 742097 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.1%-2.9% regression in system_health.memory_mobile at 485212:485308

Project Member Reported by petermarshall@chromium.org, Jul 13 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 13 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=742097

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=2d77be17779646e33385b5951630d94a2c2bbda8c6322ef72b2936370a934916


Bot(s) for this bug's original alert(s):

android-nexus5X
android-nexus6
android-nexus7v2
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 13 2017

Cc: rmcilroy@chromium.org
Owner: rmcilroy@chromium.org

=== Auto-CCing suspected CL author rmcilroy@chromium.org ===

Hi rmcilroy@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Ross McIlroy
  Commit : d425306d53c871016f3d1cfefd0aa1d24edf1181
  Date   : Fri Jul 07 10:19:39 2017
  Subject: Reland: Enable StringConcat bytecode.

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/load_games/load_games_bubbles
  Change       : 2.23% | 5798982.28571 -> 5946001.33333

Revision                           Result                  N
chromium@485244                    5798982 +- 202887       14      good
chromium@485246                    5710479 +- 439480       9       good
chromium@485247                    5714093 +- 364513       9       good
chromium@485247,v8@bfc0bc8f83      5809437 +- 58538.9      6       good
chromium@485247,v8@166863b6b4      5831149 +- 24024.0      6       good
chromium@485247,v8@fe37d91345      5802815 +- 34900.9      6       good
chromium@485247,v8@d425306d53      5919383 +- 47019.2      6       bad       <--
chromium@485247,v8@17001a05c8      5923629 +- 61465.6      6       bad
chromium@485248                    5859786 +- 520937       14      bad
chromium@485251                    5924311 +- 152396       9       bad
chromium@485260                    5879103 +- 559989       14      bad
chromium@485276                    5948573 +- 57292.6      9       bad
chromium@485308                    5946001 +- 37523.4      6       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.bubbles system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8974199254819797344


For feedback, file a bug with component Speed>Bisection
Status: Fixed (was: Untriaged)
The change is already reverted, so should be recover once the bots catch up.

Sign in to add a comment