New issue
Advanced search Search tips

Issue 742093 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 740804



Sign in to add a comment

Move SelectionTemplate::IsHandleVisible() to FrameSelection

Project Member Reported by yosin@chromium.org, Jul 13 2017

Issue description

Handle visibility is FrameSelection specific information, we don't need to
have it in SelectionTemplate.
 

Comment 1 by yosin@chromium.org, Jul 13 2017

Components: Blink>Editing>Selection
Labels: -Type-Bug Type-Task
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e7fe6a871007853a0f5689fb7193b72a36bd1b0

commit 2e7fe6a871007853a0f5689fb7193b72a36bd1b0
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Wed Jul 19 06:35:16 2017

Utilize TypingContinuation in InputMethodController

This patch changes |InputMethodController| to utilize |TypingContinuation| on
 - SetEditableSelectionOffsets()
 - SetSelectionOffsets()
to avoid using |FrameSelection::SetSelectionOptions| as a preparation of the
patch[1].

And byproduct, this patch removes include-directive of "FrameSelection.h"
from "InputMethodController.h" for faster compilation and abstract the
parameter of |SetSelectionOptions()| and |SetEditableSelectionOffsets()|
for improving code health.

[1] http://crrev.com/c/569662: Introduce SetSelectionData for
FrameSelection::SetSelection()

Bug:  742093 
Change-Id: I2a41772f7d773401e619f1c3a5969a148a4164e3
Reviewed-on: https://chromium-review.googlesource.com/576414
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487771}
[modify] https://crrev.com/2e7fe6a871007853a0f5689fb7193b72a36bd1b0/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/2e7fe6a871007853a0f5689fb7193b72a36bd1b0/third_party/WebKit/Source/core/editing/InputMethodController.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f2f98f725ba57d01ebd775ef897a05e65092864

commit 7f2f98f725ba57d01ebd775ef897a05e65092864
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Wed Jul 19 08:32:47 2017

Get rid of flat tree version of FrameSelection::SetSelection()

This patch gets rid of flat tree version of |FrameSelection::SetSelection()|
by replacing call sites to use dom tree version with introducing
|ConvertToSelectionInDOMTree()| since flat tree version of |SetSelection()| is
used only in |SelectionController| as a preparation of the patch[1].

[1] http://crrev.com/c/569662: Introduce SetSelectionData for
FrameSelection::SetSelection()

Bug:  742093 
Change-Id: I8fc5bb7b28ebd4e2f699e5ca721870430539f736
Reviewed-on: https://chromium-review.googlesource.com/577334
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487793}
[modify] https://crrev.com/7f2f98f725ba57d01ebd775ef897a05e65092864/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/7f2f98f725ba57d01ebd775ef897a05e65092864/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/7f2f98f725ba57d01ebd775ef897a05e65092864/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/7f2f98f725ba57d01ebd775ef897a05e65092864/third_party/WebKit/Source/core/editing/SelectionController.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/722a0483dfdbe1256f9abe3d6b9d56228cd155f4

commit 722a0483dfdbe1256f9abe3d6b9d56228cd155f4
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Wed Jul 26 05:19:32 2017

Introduce SetSelectionData for FrameSelection::SetSelection()

This patch introduces |SetSelectionData| and |SetSelectionData| version of
|FrameSelection::SetSelection()| to simplify |SetSelection()| of
|FrameSelection|.

Following patch will be changes other call sites of |SetSelection()| to
use |SetSelectionData| version[1] and remove |SetSelectionOptions| from
|FrameSelection| class.

[1] http://crrev.com/c/569662 ALL-IN-ONE Introduce SetSelectionData for
FrameSelection::SetSelection()

Bug:  742093 
Change-Id: Ic7d89de0e34871eee8a769dd962ec912a82ce644
Reviewed-on: https://chromium-review.googlesource.com/584688
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489555}
[modify] https://crrev.com/722a0483dfdbe1256f9abe3d6b9d56228cd155f4/third_party/WebKit/Source/core/editing/BUILD.gn
[modify] https://crrev.com/722a0483dfdbe1256f9abe3d6b9d56228cd155f4/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/722a0483dfdbe1256f9abe3d6b9d56228cd155f4/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/722a0483dfdbe1256f9abe3d6b9d56228cd155f4/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[add] https://crrev.com/722a0483dfdbe1256f9abe3d6b9d56228cd155f4/third_party/WebKit/Source/core/editing/SetSelectionData.cpp
[add] https://crrev.com/722a0483dfdbe1256f9abe3d6b9d56228cd155f4/third_party/WebKit/Source/core/editing/SetSelectionData.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d86709e2200264d5af2b79cad6d6ad80c4f70259

commit d86709e2200264d5af2b79cad6d6ad80c4f70259
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Wed Jul 26 18:34:20 2017

Utilize SetSelectionData in InputMethodController.cpp

This patch changes call sites of FrameSelection::SetSelection() in
"InputMethodController.cpp" to use |SetSelectionData| for a preparation of the
patch[1].

[1] http://crrev.com/c/569662 Get rid of FrameSelection::SetSelectionOptions

Bug:  742093 
Change-Id: I40f17e47a6246b4e9a2e47169862106f3ac554ce
Reviewed-on: https://chromium-review.googlesource.com/586067
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489705}
[modify] https://crrev.com/d86709e2200264d5af2b79cad6d6ad80c4f70259/third_party/WebKit/Source/core/editing/InputMethodController.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20c8e0f01a243bd69a0e5f3e79da42f369e9bfd5

commit 20c8e0f01a243bd69a0e5f3e79da42f369e9bfd5
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Jul 27 01:26:31 2017

Utilize SetSelectionData in Range.cpp

This patch changes call sites of FrameSelection::SetSelection() in
"Rang.cpp" to use |SetSelectionData| for a preparation of the patch[1].

[1] http://crrev.com/c/569662 Get rid of FrameSelection::SetSelectionOptions

Bug:  742093 
Change-Id: Ib4e96ff5b8d38bc36ccd7f228f457c003e2f0500
Reviewed-on: https://chromium-review.googlesource.com/585341
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489829}
[modify] https://crrev.com/20c8e0f01a243bd69a0e5f3e79da42f369e9bfd5/third_party/WebKit/Source/core/dom/Range.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25d7544828fc9eb86a66aa40fb0694a0721e8cb3

commit 25d7544828fc9eb86a66aa40fb0694a0721e8cb3
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Jul 27 01:26:39 2017

Utilize SetSelectionData in Element.cpp

This patch changes call sites of FrameSelection::SetSelection() in
"Element.cpp" to use |SetSelectionData| for a preparation of the patch[1].

[1] http://crrev.com/c/569662 Get rid of FrameSelection::SetSelectionOptions

Bug:  742093 
Change-Id: If594190d2af6b5e0f86363d73b6e74fdfee31b9a
Reviewed-on: https://chromium-review.googlesource.com/585993
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489830}
[modify] https://crrev.com/25d7544828fc9eb86a66aa40fb0694a0721e8cb3/third_party/WebKit/Source/core/dom/Element.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2215474371f2af929197402f0e0a380e1b4a2fa6

commit 2215474371f2af929197402f0e0a380e1b4a2fa6
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Jul 27 01:31:42 2017

Utilize SetSelectionData in EditorCommand.cpp

This patch changes call sites of FrameSelection::SetSelection() in
"EditorCommand.cpp" to use |SetSelectionData| for a preparation of the patch[1].

[1] http://crrev.com/c/569662 Get rid of FrameSelection::SetSelectionOptions

Bug:  742093 
Change-Id: I6b9c3fb9ac6dd3973f8d92231f2a039e88c0f0f9
Reviewed-on: https://chromium-review.googlesource.com/586012
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489833}
[modify] https://crrev.com/2215474371f2af929197402f0e0a380e1b4a2fa6/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed4f4d0a45f8f2998c07cccf37f5277190b14262

commit ed4f4d0a45f8f2998c07cccf37f5277190b14262
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Jul 27 02:08:44 2017

Utilize SetSelectionData in Editor.cpp

This patch changes call sites of FrameSelection::SetSelection() in
"Editor.cpp" and |Editor::ChangeSelectionAfterCommand()| to use 
|SetSelectionData| for a preparation of the patch[1].

[1] http://crrev.com/c/569662 Get rid of FrameSelection::SetSelectionOptions

Bug:  742093 
Change-Id: I86f32fef5886c13bfddee110b845a7e0103e0225
Reviewed-on: https://chromium-review.googlesource.com/586047
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489838}
[modify] https://crrev.com/ed4f4d0a45f8f2998c07cccf37f5277190b14262/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/ed4f4d0a45f8f2998c07cccf37f5277190b14262/third_party/WebKit/Source/core/editing/Editor.h

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0abcf3b4d587c919e50893bd8c9c0a53489e08e

commit c0abcf3b4d587c919e50893bd8c9c0a53489e08e
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Jul 27 03:46:07 2017

Utilize SetSelectionData in TextControlElement.cpp

This patch changes call sites of FrameSelection::SetSelection() in
"TextControlElement.cpp" to use |SetSelectionData| for a preparation of the
patch[1].

[1] http://crrev.com/c/569662 Get rid of FrameSelection::SetSelectionOptions

Bug:  742093 
Change-Id: I976090d4d6b0a1fe35e4935de8e68e18478da106
Reviewed-on: https://chromium-review.googlesource.com/586071
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489848}
[modify] https://crrev.com/c0abcf3b4d587c919e50893bd8c9c0a53489e08e/third_party/WebKit/Source/core/html/TextControlElement.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61816d6dcea550142d2f9e88e4767f0533f6c8d3

commit 61816d6dcea550142d2f9e88e4767f0533f6c8d3
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Jul 27 03:46:59 2017

Utilize SetSelectionData in SelectionController.cpp

This patch changes call sites of FrameSelection::SetSelection() in
"SelectionController.cpp" to use |SetSelectionData| for a preparation of the
patch[1].

[1] http://crrev.com/c/569662 Get rid of FrameSelection::SetSelectionOptions

Bug:  742093 
Change-Id: If6abf86cf00023c788655073512ab18936f95aaf
Reviewed-on: https://chromium-review.googlesource.com/586069
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489849}
[modify] https://crrev.com/61816d6dcea550142d2f9e88e4767f0533f6c8d3/third_party/WebKit/Source/core/editing/SelectionController.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6b2104e0c13280ed93eae650623da9cc94709e1

commit b6b2104e0c13280ed93eae650623da9cc94709e1
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Jul 27 04:15:45 2017

Utilize SetSelectionData in WebLocalFrameImpl.cpp

This patch changes call sites of FrameSelection::SetSelection() in
"WebLocalFrameImpl.cpp" to use |SetSelectionData| for a preparation of the
patch[1].

[1] http://crrev.com/c/569662 Get rid of FrameSelection::SetSelectionOptions

Bug:  742093 
Change-Id: Id6dbd914abebf4d3b0d4dcc343e02774c999511b
Reviewed-on: https://chromium-review.googlesource.com/586070
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489855}
[modify] https://crrev.com/b6b2104e0c13280ed93eae650623da9cc94709e1/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp

Comment 13 by yosin@chromium.org, Jul 27 2017

Blocking: 740804
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/156bdb7ab6a629bd3b4ffa5d6b00cd9974749486

commit 156bdb7ab6a629bd3b4ffa5d6b00cd9974749486
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Fri Jul 28 03:26:02 2017

Fix copyright year in SetSelectionData.{cpp,h}

This patch changes copyright year in "SetSelectionData.{cpp,h}" to 2017 since
these files are added to repository in 2017 as follow-up of the patch[1].

[1] http://crrev.com/c/584688: Introduce SetSelectionData for
FrameSelection::SetSelection()

Bug:  742093 
Change-Id: Id1fcd2fc652c83e3564b2c62ae550df68c718969
Reviewed-on: https://chromium-review.googlesource.com/588038
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490237}
[modify] https://crrev.com/156bdb7ab6a629bd3b4ffa5d6b00cd9974749486/third_party/WebKit/Source/core/editing/SetSelectionData.cpp
[modify] https://crrev.com/156bdb7ab6a629bd3b4ffa5d6b00cd9974749486/third_party/WebKit/Source/core/editing/SetSelectionData.h

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcf334a19f30ea3f06e8a1960ee37e098f4333aa

commit bcf334a19f30ea3f06e8a1960ee37e098f4333aa
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Fri Jul 28 03:34:37 2017

Utilize SetSelectionData in FrameSelection.cpp

This patch changes call sites of FrameSelection::SetSelection() in
"FrameSelection.cpp" to use |SetSelectionData| for a preparation of the
patch[1].

[1] http://crrev.com/c/569662 Get rid of FrameSelection::SetSelectionOptions

Bug:  742093 
Change-Id: Ic205f7798584d2aee4496c8b1b0252cb9e6c1414
Reviewed-on: https://chromium-review.googlesource.com/588608
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490242}
[modify] https://crrev.com/bcf334a19f30ea3f06e8a1960ee37e098f4333aa/third_party/WebKit/Source/core/editing/FrameSelection.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56d1549e622b1552ddd8dbe7a8bfd3e95a2cc8f5

commit 56d1549e622b1552ddd8dbe7a8bfd3e95a2cc8f5
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Fri Jul 28 10:19:07 2017

Get rid of FrameSelection::SetSelectionOptions

This patch gets rid of |FrameSelection::SetSelectionOptions| by utilizing
|SetSelectionData| in |SetSelection()| and |DidSetSelection()| to simplify
code base for improving code health.

Bug:  742093 
Change-Id: I4f16011153340960e6b5e713c3b130c8d2d61fe2
Reviewed-on: https://chromium-review.googlesource.com/569662
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490349}
[modify] https://crrev.com/56d1549e622b1552ddd8dbe7a8bfd3e95a2cc8f5/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/56d1549e622b1552ddd8dbe7a8bfd3e95a2cc8f5/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/56d1549e622b1552ddd8dbe7a8bfd3e95a2cc8f5/third_party/WebKit/Source/core/editing/FrameSelection.h

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33827275411b33371e7bb750cce20f11de85002d

commit 33827275411b33371e7bb750cce20f11de85002d
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Aug 03 06:05:35 2017

Move SelectionTemplate::is_handle_visible_ to FrameSelection

This patch moves |is_handle_visible_| to |FrameSelection| from |SelectionTemplate|
since handle visibility is used only for setting |FrameSelection|, hence it is
a redundant member variable of |SelectionTemplate|.

Bug:  742093 
Change-Id: I3add4da3844fb40be34dcb4d4b46b5fa6fed1d7e
Reviewed-on: https://chromium-review.googlesource.com/595389
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491660}
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/SelectionTemplate.cpp
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/SelectionTemplate.h
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/SelectionTemplateTest.cpp
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/SetSelectionData.cpp
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/editing/SetSelectionData.h
[modify] https://crrev.com/33827275411b33371e7bb750cce20f11de85002d/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp

Status: Fixed (was: Started)

Sign in to add a comment