New issue
Advanced search Search tips

Issue 742053 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

linear-gradient is not displayed in table rows (TR)

Reported by m1miy...@gmail.com, Jul 13 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3155.0 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. Open sample.html in Chrome 61 Canary Channel

What is the expected behavior?
Gradient color is displayed in the first row in the table

What went wrong?
Gradient color is not displayed in the first row in the table

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes Chrome 60 Beta Channel

Does this work in other browsers? Yes

Chrome version: 61.0.3155.0  Channel: canary
OS Version: 10.0
Flash Version: Shockwave Flash 24.0 r0

linear-gradient is not displayed if it is used in table row (TR).
It is displayed in table cell (TD).
 
sample.html
2.5 KB View Download

Comment 1 by junov@chromium.org, Jul 13 2017

Components: -Blink Blink>Paint
Labels: -OS-Windows -Type-Bug -Pri-2 M-61 ReleaseBlock-Stable OS-All Pri-1 Type-Bug-Regression
Owner: e...@chromium.org
Status: Assigned (was: Unconfirmed)
Was able to repro on linux

Bisect gave this regression range:
https://chromium.googlesource.com/chromium/src/+log/2e7cc531fa2f94cb10bf706bbb129753484ad46c..dbee1802f2e088c5290d262eac0b34fd1de32247

Suspecting: https://chromium.googlesource.com/chromium/src/+/dbee1802f2e088c5290d262eac0b34fd1de32247

Assigning to eae@

Labels: PaintTeamTriaged-20170713 BugSource-Chromium

Comment 3 by e...@chromium.org, Jul 13 2017

Status: Started (was: Assigned)

Comment 4 by e...@chromium.org, Jul 13 2017

Thanks for the minimized test case, made it a lot easier to track down the bug.

Fix in review.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a3b73626885c33ac641ba8abb1dce6359546a65

commit 2a3b73626885c33ac641ba8abb1dce6359546a65
Author: Emil A Eklund <eae@chromium.org>
Date: Fri Jul 14 16:35:16 2017

Fix background image painting for table cells

In r484771 the painting logic for table cells and rows with a background
image was inadvertently changed as a part of a refactoring. This in turn
led to the wrong ImageClient being used in cases where the background is
set on the table row as opposed to the cell.

The bug was introduced between patch set 3 and 4 of the original change.

This CL restores the original behavior by using the correct ImageClient.

TEST=fast/table/backgr_on_table_row.html
BUG= 742053 
R=pdr@chromium.org

Change-Id: I7316ddf34698ba78d43067dd46610ece628ef7fe
Reviewed-on: https://chromium-review.googlesource.com/571158
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486775}
[add] https://crrev.com/2a3b73626885c33ac641ba8abb1dce6359546a65/third_party/WebKit/LayoutTests/fast/table/backgr_on_table_row-expected.html
[add] https://crrev.com/2a3b73626885c33ac641ba8abb1dce6359546a65/third_party/WebKit/LayoutTests/fast/table/backgr_on_table_row.html
[modify] https://crrev.com/2a3b73626885c33ac641ba8abb1dce6359546a65/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp

Comment 6 by e...@chromium.org, Jul 14 2017

Status: Fixed (was: Started)

Sign in to add a comment