Regression: [DevTools] NTP is not seen properly after recording the Audit.
Reported by
dchau...@etouch.net,
Jul 13 2017
|
|||||||||
Issue descriptionChrome Version: 61.0.3156.0 (Official Build)7a4241c698a71a5cc10ec6135060f4d99af2b96c-refs/heads/master@{#486205} 32/64-bit. OS: Windows(7,8,10) What steps will reproduce the problem? (1) Launch chrome, go to NTP, open dev tools window and navigate to Audit section. (2) Click on Perform and audit button and then click on Run audit button to record it. (3) Now, observe the NTP. NTP is not seen properly. NTP should seen properly. This is a regression issue, broken in M-61 series, will soon pdate other info.
,
Jul 13 2017
Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/7577c2eff30d9627418258e3083524f2c7d878db..8bc8e844008bd1d33ed524fdef69f1c300e4b6b0?pretty=fuller&n=100 Suspecting: r486136 ? @phulce: Kindly help to reassign, if your changes are not related to this issue.
,
Jul 13 2017
Adding Release Block-Stable for this issue.Please remove if not the case. Thank You!
,
Jul 13 2017
r486136 was a fix for an issue that was probably masking the underlying bug from previous revision (since an audit couldn't be run at all in 61.0.3155.0) @pfeldman could this be related to emulation/viewport changes made recently?
,
Jul 13 2017
,
Jul 13 2017
There seem to be multiple issues at play here, the emulation size not returning to normal as observed in the "Actual" video above, and the wrong URL is being audited when there are multiple targets on the page. I'm investigating the latter, reassigned for the described issue of NTP appearance issues.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12ed41235b2ec901fc7a3512e2aa5fcacf7a6229 commit 12ed41235b2ec901fc7a3512e2aa5fcacf7a6229 Author: Patrick Hulce <phulce@chromium.org> Date: Fri Jul 14 21:09:27 2017 DevTools: return the correct defaultExecutionContext * Uses the sorted list by frame to determine the defaultExecutionContext. * Fixes issue where Audits panel would audit the wrong URL. BUG= 742044 Change-Id: I56a1ebd0a0d1f2f9decd603f78c5b73921ea635e Reviewed-on: https://chromium-review.googlesource.com/570921 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Patrick Hulce <phulce@chromium.org> Cr-Commit-Position: refs/heads/master@{#486888} [modify] https://crrev.com/12ed41235b2ec901fc7a3512e2aa5fcacf7a6229/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js [modify] https://crrev.com/12ed41235b2ec901fc7a3512e2aa5fcacf7a6229/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
,
Jul 18 2017
Retested this issue on Windows, Mac and Linux machine using Dev build #61.0.3159.5 (Official Build). It's still reproducible. Attaching screen-cast for the same.
,
Jul 26 2017
Rechecked this issue on Windows 10 and Mac 10.11.6 OS using chrome version 61.0.3163.13 and fix is working as expected i.e. NTP is seen properly after running the audit. Attaching screen-cast for the same.
,
Jul 26 2017
Retested this issue on Linux 14.04 OS using build #61.0.3163.13 and fix is working as intended.
,
Jul 26 2017
URGENT - PTAL. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the M61 branch #3163 ASAP to have enough baking time in Beta before Stable promotion. Thank you! Know that this issue shouldn't block the release? Remove the ReleaseBlock-Stable label.
,
Aug 4 2017
Can this issue be marked as Fixed as issue is already verified on M61 Builds (Ref Comment#9, 10) Thanks.!
,
Aug 9 2017
[Bulk Edit] URGENT - PTAL. Your bug is labelled as M61 Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Know that this issue shouldn't block the release? Remove the ReleaseBlock-Stable label. Thank you.
,
Aug 14 2017
marking the bug as "Fixed" since the CL has been merged to M61 and got verified by test team.
,
Aug 14 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Aug 14 2017
There is no M61 merge is needed here. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dchau...@etouch.net
, Jul 13 20171.4 MB
1.4 MB View Download
1.1 MB
1.1 MB View Download